Consolidate build profiles between libnd4j and nd4j modules #5813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reverts to always using the same build directories for libnd4j to do without symbolic links, which are no longer useful now that we use the Maven Assembly Plugin for that purpose.
sshepel
reviewed
Jul 5, 2018
| @@ -112,7 +112,6 @@ | |||
| <includePath>${libnd4jhome}/include/indexing</includePath> | |||
| </includePaths> | |||
| <linkPaths> | |||
| <linkPath>${libnd4jhome}/blasbuild/cuda-${cuda.version}/blas</linkPath> | |||
There was a problem hiding this comment.
Hm, I would rather keep CUDA version, just in case if someone want to build several CUDA backends on same machine...
But, I may be wrong...
There was a problem hiding this comment.
That was just a build directory created by libnd4j, but it won't use it anymore. It's all in "cuda" now like it was before I tried making this work with symbolic links.
There was a problem hiding this comment.
Yeap, I remember that, ok then.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts to always using the same build directories for libnd4j
to do without symbolic links, which are no longer useful now
that we use the Maven Assembly Plugin for that purpose.
Works fine for Linux with CUDA and Android, should work fine for all other platforms...