Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDVariable Improvements #7371

Merged
merged 4 commits into from
Mar 27, 2019
Merged

SDVariable Improvements #7371

merged 4 commits into from
Mar 27, 2019

Conversation

rnett
Copy link
Contributor

@rnett rnett commented Mar 27, 2019

What changes were proposed in this pull request?

Fixing:

How was this patch tested?

  • Unit tests for invertPermutation

Should I add unit tests for the SDVar methods? They all call already implemented methods.

@rnett rnett changed the title [WIP] SDVar Improvements [WIP] SDVariable Improvements Mar 27, 2019
@rnett
Copy link
Contributor Author

rnett commented Mar 27, 2019

I can add a permute(long...) that just casts to int, is that useful enough to be worth it? I always end up using ints.

@rnett rnett changed the title [WIP] SDVariable Improvements SDVariable Improvements Mar 27, 2019
Copy link
Contributor

@AlexDBlack AlexDBlack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Should I add unit tests for the SDVar methods? They all call already implemented methods.

Because they call existing methods (which are well tested), I think we can safely skip tests for these.

I can add a permute(long...) that just casts to int, is that useful enough to be worth it? I always end up using ints.

No, we don't need that that. INDArray only has integer permute. As a general rule, we use longs for shapes/lengths, ints for dimensions/axis.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants