Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDVariable Improvements #7371

Merged
merged 4 commits into from Mar 27, 2019

Conversation

Projects
None yet
2 participants
@rnett
Copy link
Contributor

commented Mar 27, 2019

What changes were proposed in this pull request?

Fixing:

How was this patch tested?

  • Unit tests for invertPermutation

Should I add unit tests for the SDVar methods? They all call already implemented methods.

@rnett rnett changed the title [WIP] SDVar Improvements [WIP] SDVariable Improvements Mar 27, 2019

rnett added some commits Mar 27, 2019

@rnett

This comment has been minimized.

Copy link
Contributor Author

commented Mar 27, 2019

I can add a permute(long...) that just casts to int, is that useful enough to be worth it? I always end up using ints.

@rnett rnett changed the title [WIP] SDVariable Improvements SDVariable Improvements Mar 27, 2019

@AlexDBlack
Copy link
Member

left a comment

LGTM 👍

Should I add unit tests for the SDVar methods? They all call already implemented methods.

Because they call existing methods (which are well tested), I think we can safely skip tests for these.

I can add a permute(long...) that just casts to int, is that useful enough to be worth it? I always end up using ints.

No, we don't need that that. INDArray only has integer permute. As a general rule, we use longs for shapes/lengths, ints for dimensions/axis.

@AlexDBlack AlexDBlack merged commit 88d4acb into deeplearning4j:master Mar 27, 2019

0 of 2 checks passed

Codacy/PR Quality Review Not up to standards. This pull request quality could be better.
Details
continuous-integration/jenkins/pr-head This commit is being built
Details

@rnett rnett deleted the rnett:rnett-sdvar branch Mar 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.