Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable map creation log printing #54

Closed
edran opened this issue Mar 21, 2017 · 4 comments
Closed

Disable map creation log printing #54

edran opened this issue Mar 21, 2017 · 4 comments
Assignees

Comments

@edran
Copy link

edran commented Mar 21, 2017

Is there any way to disable all the printing that occurs when creating a map? I can see that the logs are being saved (to e.g. bspc.log - any way to parametrise this too by any chance?), so there is no need to show the output from bsp2aas and similar tools.

Plus this gets quite troublesome when running multiple environments in the same binary. 😃

@tkoeppe
Copy link
Collaborator

tkoeppe commented Mar 21, 2017

You can try adding > /dev/null in places to compile_map.sh, that should get rid of most of the output. (We didn't make this parametrizable because worst case it would make it hard to see errors, and we weren't too bothered by the output.)

@edran
Copy link
Author

edran commented Mar 21, 2017

Cool, thanks.

I think it'd be great to have a flag at build time to do this, so I may send a patch if I end up doing this automatically (as opposed to manually patching the result of bazel build directly).

@tkoeppe tkoeppe self-assigned this Nov 28, 2017
@tkoeppe
Copy link
Collaborator

tkoeppe commented Nov 28, 2017

Hm, I don't think this behaviour can be changed at build time, since the shell script doesn't get "built". It's just run as-is.

In the upcoming update, we've replaced std::system with popen and we only print the output if there was an error, so that should help matters.

@tkoeppe
Copy link
Collaborator

tkoeppe commented Jan 2, 2018

Fixed by 91d29b8.

@tkoeppe tkoeppe closed this as completed Jan 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants