Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the norm of complex numbers in clipping #161

Closed
wants to merge 3 commits into from
Closed

Fix the norm of complex numbers in clipping #161

wants to merge 3 commits into from

Conversation

wdphy16
Copy link
Contributor

@wdphy16 wdphy16 commented Jul 17, 2021

Fixes #144

@google-cla google-cla bot added the cla: yes copybara label for automatic import label Jul 17, 2021
@wdphy16 wdphy16 mentioned this pull request Jul 17, 2021
Closed
@PhilipVinc
Copy link

Bump. can this be merged?

@PhilipVinc
Copy link

Bump @mkunesch @rosshemsley , can this be reviewed and eventually merged?

@wdphy16
Copy link
Contributor Author

wdphy16 commented Oct 12, 2021

Bump @mkunesch @rosshemsley @fabioviola , any update on this?

@PhilipVinc
Copy link

Bump again. I'm going to try my luck with @hbq1 .
I'm sorry we are so insistent but we'd love this merged.
Or if optax is more of an internal deepmind project that is not open for external contributions we'd love to know...

@rosshemsley
Copy link
Collaborator

Thanks for the pull request, and apologies for the delay in responding.

We've been trying to decide what to do on this issue - one of the challenges is that complex numbers are not yet officially supported in optax, and so we want to be careful of adding support in an inconsistent way to the library.

Optax is also used by a number of models where performance is an important consideration, so there is some concern that this alternative factoring could negatively affect performance of those models in a way that would be hard to test for regressions.

There is wider interest for complex numbers in optax though - (#196), and we're keen to engage with this effort!

One possible (temporary) solution in this case would be to implement an independent clipper specifically for complex numbers. Could that be an option in this case?

@wdphy16 wdphy16 mentioned this pull request Jan 14, 2022
Merged
@wdphy16
Copy link
Contributor Author

wdphy16 commented Jan 24, 2022

Closed in favor of #279

@wdphy16 wdphy16 closed this Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkunesch mkunesch Awaiting requested review from mkunesch

@rosshemsley rosshemsley Awaiting requested review from rosshemsley

Assignees
No one assigned
Labels
cla: yes copybara label for automatic import
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Norm of complex numbers
3 participants
@wdphy16 @PhilipVinc @rosshemsley