Bot kg annotator #586

annakorz · 2023-10-31T12:17:09Z

Bot-knowledge-memorizer to store and retrieve data into/from bot's knowledge graph
dream_bot_kg_prompted distribution with dff-bot-knowledge-prompted-skill that demonstrates bot-km in action

IMPORTANT: not to delete the branch after merge

…king

This let us avoid assertion error about lists lengths in deeppavlov-kg

This fixes the problem of storing the same entity many times

This prevents creating the same entity many times in KG

* component card changed in pipeline_conf * sentence-ranker url removed from .env

* changes in bot-km server file * custom-el formatter changed

dilyararimovna · 2023-12-08T08:09:24Z

annotators/property_extraction/rel_groups.pickle

all weights/models files should be downloaded from files.deeppavlov NOT stored in github.

@zucchini-nlp

removed, prob it was merged from old branches

dilyararimovna · 2023-12-08T08:09:59Z

annotators/property_extraction/server.py

@@ -154,6 +154,12 @@ def generate_triplets(uttr_batch, relations_pred_batch):
    return triplets_corr_batch


+def is_question(uttr: str):
+    uttr = uttr.lower()
+    is_q = any([uttr.startswith(q_word) for q_word in ["what ", "who ", "when ", "where "]]) or "?" in uttr


we have the same function to use in common (like is_any_question - i do not remember the title clearly but try to find it and use it)

@zucchini-nlp

there is only is_questions that checks for question marks or another for factoid-only questions in common.utils.py

is_any_question from common.universal_templates.py does not fit in my case. I am checking each sentence and filtering out questions from it, bu tthe function checks the whole uttr from annotations

not repeating templates you still can do the following:
is_yes({"text": sentence, "annotations": {}})

dilyararimovna · 2023-12-08T08:11:53Z

assistant_dists/dream_kg/docker-compose.override.yml

@@ -219,6 +219,7 @@ services:
    command: flask run -h 0.0.0.0 -p 8020
    environment:
      - FLASK_APP=server
+      - CUDA_VISIBLE_DEVICES=0


do you have this info in your component and containers cards?

dilyararimovna · 2023-12-08T08:12:09Z

assistant_dists/dream_kg/docker-compose.override.yml

@@ -238,9 +239,9 @@ services:
    deploy:
      resources:
        limits:
-          memory: 128M
+          memory: 512M


did you increase the value in component/container cards?

No, this should stay unchanged.
Reverted

skills/dff_knowledge_prompted_skill/Dockerfile

dilyararimovna · 2023-12-08T08:13:10Z

skills/dff_knowledge_prompted_skill/Dockerfile

@@ -37,4 +37,7 @@ ENV ENVVARS_TO_SEND ${ENVVARS_TO_SEND}
 ARG USE_KG_DATA
 ENV USE_KG_DATA=$USE_KG_DATA

+ARG USE_BOT_KG_DATA


Suggested change

ARG USE_BOT_KG_DATA

ARG USE_BOT_KG_DATA=0

otherwise in the server.py getting these vars from env will get you None values (not 0 as you pointed out in deault)

Thanks for suggestion. Added default value to Dockerfile.

dilyararimovna · 2023-12-08T08:13:19Z

skills/dff_knowledge_prompted_skill/Dockerfile

@@ -37,4 +37,7 @@ ENV ENVVARS_TO_SEND ${ENVVARS_TO_SEND}
 ARG USE_KG_DATA


Suggested change

ARG USE_KG_DATA

ARG USE_KG_DATA=0

dilyararimovna · 2023-12-08T08:46:27Z

state_formatters/dp_formatters.py

+    dialog = utils.get_last_n_turns(dialog, bot_last_turns=1)
+    dialog = utils.replace_with_annotated_utterances(dialog, mode="punct_sent")
+    if len(dialog["bot_utterances"]):
+        context = [dialog["bot_utterances"][-1]["text"]]


state_formatters/dp_formatters.py

dilyararimovna · 2023-12-08T08:48:38Z

state_formatters/dp_formatters.py

+    dialog = utils.get_last_n_turns(dialog, bot_last_turns=1)
+    dialog = utils.replace_with_annotated_utterances(dialog, mode="punct_sent")
+    if len(dialog["utterances"]) >= 2:
+        dialog_history = [dialog["utterances"][-2]["text"]]


should it be last humn uttr? I do not get what utterance you are trying to get to history

@zucchini-nlp

should be last bot utterance, fixed it

…ot_kg_annotator

* USE_KG_DATA and USE_BOT_KG_DATA

dilyararimovna · 2023-12-11T05:27:38Z

annotators/property_extraction/server.py

@@ -154,6 +154,12 @@ def generate_triplets(uttr_batch, relations_pred_batch):
    return triplets_corr_batch


+def is_question(uttr: str):
+    uttr = uttr.lower()
+    is_q = any([uttr.startswith(q_word) for q_word in ["what ", "who ", "when ", "where "]]) or "?" in uttr


not repeating templates you still can do the following:
is_yes({"text": sentence, "annotations": {}})

dilyararimovna · 2023-12-11T05:34:44Z

annotators/property_extraction/server.py

-                uttrs.append(sentrewrite(utt_prev_l, utt_cur_l))
+    if not init_uttrs[0][0]:
+        triplets_batch = [[""]]
+        uttrs = [""]


that's a strange check for me. You jsut check the first element and assign uttrs to list of empty string. But you are not sure that there is only one element. And why do you do this here?
Probably it;'s better to iterate over the batch of input and check every sample and append to uttr empty string if the input init_uttrs[i] is empty (or whatever check is)

@zucchini-nlp

this was all used to manage empty or very long bot utterances. Now, I removed the check for empty and moved it for later when iterating the utterances. The is_question function is also removed and I reverted the question-check to the way it was before.

dilyararimovna · 2023-12-11T05:35:45Z

state_formatters/dp_formatters.py

+        entity_substr_list, entity_tags_list, context = prepare_el_input_last_bot(dialog)
+    else:
+        entity_substr_list, entity_tags_list, context = [""], [""], [""]
+    return [{"entity_substr": [entity_substr_list], "entity_tags": [entity_tags_list], "context": [context]}]


in another PR I have already asked for that, so I have to ask you too))
As these are batches, please name them in multiple way, so contexts not `context1 (and in your formatters bellow)

* changes reflected in services server-files * style format

* returns the output in the usual form and prevents skill from error

* property-extraction * entity-detection * entity-linking * custom-entity-linking * ner * response_selector * bot-knowledge-memorizer * dff-bot-knowledge-prompted-skill

* changes reflected in service_configs for dream_kg_prompted and dream_bot_kg_prompted

dilyararimovna · 2023-12-12T11:08:33Z

components/YJzc7NwGrLmKp6gfZJh7Xs.yml

@@ -0,0 +1,26 @@
+name: response_selector
+display_name: Ranking-based Response Selector


you do not need a new card for this response selector because it is already existing

YJzc7NwGrLmKp6gfZJh7X1.yml

dilyararimovna · 2023-12-12T11:10:23Z

components/U5vEOIpvZ4iaIolONGpj0y.yml

@@ -0,0 +1,26 @@
+name: ner
+display_name: NER


this card already exists iBC0L15gOFWymHhZEAybUQ.yml

* bot-knowledge-prompted-skill * response_selector

assistant_dists/dream_bot_kg_prompted/pipeline_conf.json

dilyararimovna

Happy Birthday! merge like a present

dmitrijeuseew and others added 30 commits April 9, 2023 10:16

Merge remote-tracking branch 'origin/dev' into feat/custom_entity_lin…

1352b82

…king

update pipeline_conf

3eee6e7

fix: Use dream_kg pipeline for that dist

b605ea5

update: extract multiple triplets

d7a11fd

fix typo

09c8404

remove bot uttr for cuxtom-el

7b637bd

use generic relations

74966a6

fix url

6c63c66

switch to t5 lite

0505adf

chore: Update user-kg to CRUD batch operations

381fd2b

fix: Separate storing entities and relationships

3ba626f

This let us avoid assertion error about lists lengths in deeppavlov-kg

fix: Make all entities lowercase before storing

cbed2f6

This fixes the problem of storing the same entity many times

remove repetitive triplets

92ac1f9

minor fix

5b21ca9

fix: Check if entity exists in kg before adding it

612f55f

This prevents creating the same entity many times in KG

fix: Delete invalid condition

9af3755

Merge branch 'dev' into feat/new_prop_ex

5bbd9ce

fix ckpt name

4ba052d

created kg_prompted distribution

678a3e6

fix: Update name_scenario func after DP-kg changes

9382a48

chore: Modify logs

b86c19e

generative skill and prop_ext update

6cb443c

update lite model

b0cb512

Merge branch 'feat/new_prop_ex' into new_generative_kg_skill

c2f2999

fix: custom-el ports

fa94976

user-kg: prompt key to write into ctx

72c1969

remove repeating triplets with low score

4c45624

Merge branch 'feat/new_prop_ex' into new_generative_kg_skill

5c83e7e

fix: Update entity-detection file location

e1763e9

chore: Fix 'added' to return only added triplets

c6c084a

annakorz and others added 5 commits December 1, 2023 15:09

fix: removed old files and merge error

3f346ef

fix: package versions, component card

3e1bb35

* component card changed in pipeline_conf * sentence-ranker url removed from .env

fix: bot_id retrieved from context

b9c9c02

* changes in bot-km server file * custom-el formatter changed

Merge branch 'dev' into bot_kg_annotator

02dd1b7

property extraction formatter update

3814f4b

dilyararimovna requested changes Dec 8, 2023

View reviewed changes

annakorz and others added 7 commits December 8, 2023 12:28

revert: changes in dream_kg

5568433

Merge branch 'bot_kg_annotator' of github.com:deeppavlov/dream into b…

37663f3

…ot_kg_annotator

fix: prop-ex port in dream_bot_kg_prompted dist

ef11d37

fix: added default values to skill Dockerfile

42fd228

* USE_KG_DATA and USE_BOT_KG_DATA

fix: entity-detection formatter

6336de3

fix: environemnet for bot-km

8f0c725

fixes propr ex

c2ef3ce

dilyararimovna requested changes Dec 11, 2023

View reviewed changes

zucchini-nlp and others added 9 commits December 11, 2023 13:18

fix if bot uttr

fbc5cca

fix: entity-linking and custom-el formatters

af282a3

* changes reflected in services server-files * style format

Merge branch 'dev' into bot_kg_annotator

3c449af

fix: Send unique list of kinds to be created in db

779ebb0

fix: default output for bot-km

5e1149e

* returns the output in the usual form and prevents skill from error

fix: component cards for dream_bot_kg_prompted

3c7517a

* property-extraction * entity-detection * entity-linking * custom-entity-linking * ner * response_selector * bot-knowledge-memorizer * dff-bot-knowledge-prompted-skill

fix: Send unique list of kinds to be created in db

72fcd99

Merge branch 'dev' into bot_kg_annotator

70f2792

fix: sentence-ranker in args for prompt-selector

ac3b38e

* changes reflected in service_configs for dream_kg_prompted and dream_bot_kg_prompted

dilyararimovna requested changes Dec 12, 2023

View reviewed changes

dilyararimovna and others added 2 commits December 12, 2023 15:26

fix: ner component card

4d18ba3

fix: pipeline and component cards

7680b66

* bot-knowledge-prompted-skill * response_selector

dilyararimovna requested changes Dec 12, 2023

View reviewed changes

assistant_dists/dream_bot_kg_prompted/pipeline_conf.json Show resolved Hide resolved

dilyararimovna approved these changes Dec 12, 2023

View reviewed changes

dilyararimovna merged commit 442bb26 into dev Dec 12, 2023
32 checks passed

dilyararimovna deleted the bot_kg_annotator branch December 13, 2023 07:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bot kg annotator #586

Bot kg annotator #586

annakorz commented Oct 31, 2023 •

edited

Loading

dilyararimovna Dec 8, 2023

annakorz Dec 8, 2023

zucchini-nlp Dec 8, 2023

dilyararimovna Dec 8, 2023

annakorz Dec 8, 2023

zucchini-nlp Dec 8, 2023

zucchini-nlp Dec 8, 2023

dilyararimovna Dec 11, 2023

dilyararimovna Dec 8, 2023

annakorz Dec 8, 2023

dilyararimovna Dec 8, 2023

annakorz Dec 8, 2023

dilyararimovna Dec 8, 2023

dilyararimovna Dec 8, 2023

annakorz Dec 8, 2023

dilyararimovna Dec 8, 2023

annakorz Dec 8, 2023

dilyararimovna Dec 8, 2023

annakorz Dec 8, 2023

dilyararimovna Dec 8, 2023

annakorz Dec 8, 2023

zucchini-nlp Dec 8, 2023

dilyararimovna Dec 11, 2023

dilyararimovna Dec 11, 2023

annakorz Dec 11, 2023

zucchini-nlp Dec 11, 2023

dilyararimovna Dec 11, 2023

dilyararimovna Dec 12, 2023

dilyararimovna Dec 12, 2023

dilyararimovna Dec 12, 2023

dilyararimovna left a comment

		@@ -37,4 +37,7 @@ ENV ENVVARS_TO_SEND ${ENVVARS_TO_SEND}
		ARG USE_KG_DATA

		@@ -0,0 +1,26 @@
		name: response_selector
		display_name: Ranking-based Response Selector

Bot kg annotator #586

Bot kg annotator #586

Conversation

annakorz commented Oct 31, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dilyararimovna left a comment

Choose a reason for hiding this comment

annakorz commented Oct 31, 2023 •

edited

Loading