Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add: change name to dracula & cleanup and fix rust src #2

Merged
merged 1 commit into from
Jan 20, 2023
Merged

add: change name to dracula & cleanup and fix rust src #2

merged 1 commit into from
Jan 20, 2023

Conversation

swarnim-deepsource
Copy link
Contributor

@swarnim-deepsource swarnim-deepsource commented Dec 16, 2022 •
edited
Loading

Tasks Done

  • Cleanup code & fix bugs.
  • Provide a better API.
  • Simplify the no-copy flow(never copy memory after the first allocation, reference it) and add utility helpers for counting lines, guessing language from syntax, and more.
  • Ensure it works without copies and using a pull-parsing pattern.
  • Changed name to dracula

Fixes lae-6729

@linear
Copy link

linear bot commented Jan 13, 2023

LAE-6729 Refactor the `line-munch` code and provide a simplified API for use as a library

@swarnim-deepsource swarnim-deepsource changed the title add: line-munch v0.1 rust src add: change name to dracula & cleanup and fix rust src Jan 13, 2023
prajwal-deepsource
prajwal-deepsource suggested changes Jan 18, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
src/parse.rs Outdated Show resolved Hide resolved
src/parse.rs Show resolved Hide resolved
src/parse.rs Show resolved Hide resolved
@prajwal-deepsource
Copy link
Contributor

Also, a .DS_Store managed to sneak into the commits :P dump it

@prajwal-deepsource
Copy link
Contributor

@swarnim-deepsource please delete the .DS_Store file

@swarnim-deepsource swarnim-deepsource merged commit 925ae24 into master Jan 20, 2023
@swarnim-deepsource swarnim-deepsource deleted the add-line-munch branch February 14, 2023 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prajwal-deepsource prajwal-deepsource prajwal-deepsource approved these changes

@srijan-deepsource srijan-deepsource Awaiting requested review from srijan-deepsource

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@swarnim-deepsource @prajwal-deepsource