dist: updating distribution files for 2.1.2 #343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yasserf
reviewed
Mar 1, 2017
CHANGELOG.md
Outdated
| @@ -6,6 +6,7 @@ | |||
| - optimized json-path patch [#329](https://github.com/deepstreamIO/deepstream.io-client-js/pull/329) | |||
| - TypeScript typings [#283](https://github.com/deepstreamIO/deepstream.io-client-js/pull/283) and [#338](https://github.com/deepstreamIO/deepstream.io-client-js/pull/338) | |||
| - Added support for non-NaNish base 16 numbers in jsonpath [#328](https://github.com/deepstreamIO/deepstream.io-client-js/pull/328) | |||
| - There is now a single ack timeout registry for the client, shared between all handlers [#342](https://github.com/deepstreamIO/deepstream.io-client-js/pull/342) | |||
There was a problem hiding this comment.
Ack timeouts do not occur when connection is not open
Ack timeouts get cleared down when connection is lost
There was a problem hiding this comment.
Just realized a couple of edge cases where doing a snapshot or a has would be wierd when a connection drops because it won't fail due to a timeout.. but snapshots shouldn't anyways
There was a problem hiding this comment.
@yasserf, comments addressed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog and version in package.json already in master