Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dist: updating distribution files for 2.1.2 #343

Merged
merged 4 commits into from
Mar 1, 2017
Merged

dist: updating distribution files for 2.1.2 #343

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c88ce97
dist: updating distribution files for 2.1.2
Mar 1, 2017
98c5c6c
Merge branch 'master' into 2.1.2-release
Mar 1, 2017
15f435e
Changelog and dist/
Mar 1, 2017
98335f6
Changelog: adding ack timeout registry improvements
Mar 1, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
- optimized json-path patch [#329](https://github.com/deepstreamIO/deepstream.io-client-js/pull/329)
- TypeScript typings [#283](https://github.com/deepstreamIO/deepstream.io-client-js/pull/283) and [#338](https://github.com/deepstreamIO/deepstream.io-client-js/pull/338)
- Added support for non-NaNish base 16 numbers in jsonpath [#328](https://github.com/deepstreamIO/deepstream.io-client-js/pull/328)
- There is now a single ack timeout registry for the client, shared between all handlers [#342](https://github.com/deepstreamIO/deepstream.io-client-js/pull/342)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack timeouts do not occur when connection is not open
Ack timeouts get cleared down when connection is lost

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just realized a couple of edge cases where doing a snapshot or a has would be wierd when a connection drops because it won't fail due to a timeout.. but snapshots shouldn't anyways

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yasserf, comments addressed


### Bug Fixes

Expand Down