Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bamCompare --normalizeUsing and --ratio/--method #629

Closed
dpryan79 opened this issue Nov 22, 2017 · 6 comments
Closed

bamCompare --normalizeUsing and --ratio/--method #629

dpryan79 opened this issue Nov 22, 2017 · 6 comments
Milestone

Comments

@dpryan79
Copy link
Collaborator

dpryan79 commented Nov 22, 2017

  1. --ratio no longer makes much sense as an option, either --method or something like --operation would make more sense.
  2. There's still a --normalizeTo1x option (is it used though?). Presumably this should also be move to --normalizeUsing. Additionally, we have the --normalizeUsing methods AND the --scaleFactorsMethod methods. This seems a bit duplicated to me and I'd favour just making them all --normalizeUsing. I think that'd be much clearer.
@fidelram
Copy link
Collaborator

Let's change --ratio to --operation. @vivekbhr can you comment on the --normalizeTo1x?

@vivekbhr
Copy link
Member

vivekbhr commented Nov 22, 2017

I proposed the above change (#2) in order to make the options more consistent with what they do..

@dpryan79
Copy link
Collaborator Author

Consensus from in office discussion:

  1. Just use --operation
  2. Remove --normalizeTo1x in bamCompare and move it into --normalizeUsing in bamCoverage. The docs for bamCompare should clarify that "normalization" scales both samples and then does the operation, whereas "scaling" scales one sample (but not both) and then the operation is done. I think I borked this in the documentation update a bit.

@steffenheyne
Copy link
Collaborator

  1. introduce --effectiveGenomeSize option, this is only used in combination with --normalizeUsing RPGC

or?

@vivekbhr
Copy link
Member

vivekbhr commented Nov 23, 2017

Yes, since we need it only for the RPGC

@dpryan79 dpryan79 added this to the 3.0 milestone Nov 27, 2017
@dpryan79
Copy link
Collaborator Author

dpryan79 commented Jan 6, 2018

This is now merged into develop.

@dpryan79 dpryan79 closed this as completed Jan 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants