Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add timestamp to podSpec annotations force rollout on deployments #483

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

cmwylie19
Copy link
Collaborator

Description

Consecutive builds of npx pepr build or upgrading versions and rebuilding rotates tls credentials and the module code (secrets) but does not guarantee that the deployment has any updates that will force rollout.

This PR adds an timestamp annotation to the Deployment's podSpec to force a new rollout on each apply in the cluster after a build. Thanks @mjnagel

Related Issue

Fixes #477

Relates to #

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

Signed-off-by: Case Wylie <cmwylie19@defenseunicorns.com>
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@6dbf7cf). Click here to learn what that means.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #483   +/-   ##
=======================================
  Coverage        ?   83.21%           
=======================================
  Files           ?       23           
  Lines           ?      727           
  Branches        ?      123           
=======================================
  Hits            ?      605           
  Misses          ?      114           
  Partials        ?        8           
Flag Coverage Δ
pull_request 83.21% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Collaborator

@btlghrants btlghrants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we talked it through, LGTM.

@btlghrants btlghrants merged commit e6e0614 into main Jan 12, 2024
12 checks passed
@btlghrants btlghrants deleted the 477 branch January 12, 2024 16:13
jeff-mccoy pushed a commit to defenseunicorns/uds-core that referenced this pull request Jan 13, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [pepr](https://togithub.com/defenseunicorns/pepr) | [`0.21.1` ->
`0.22.0`](https://renovatebot.com/diffs/npm/pepr/0.21.1/0.22.0) |
[![age](https://developer.mend.io/api/mc/badges/age/npm/pepr/0.22.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/pepr/0.22.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/pepr/0.21.1/0.22.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/pepr/0.21.1/0.22.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>defenseunicorns/pepr (pepr)</summary>

###
[`v0.22.0`](https://togithub.com/defenseunicorns/pepr/releases/tag/v0.22.0)

[Compare
Source](https://togithub.com/defenseunicorns/pepr/compare/v0.21.1...v0.22.0)

#### Features

Make `npx pepr deploy` wait recursively for deployments to be in a
ready-state - feat: npx pepr dev does not wait for resources to be fully
up by [@&#8203;schaeferka](https://togithub.com/schaeferka) in
[defenseunicorns/pepr#435

Work on multi-versioned docs automation for the [Docs
Site](https://pepr-docs.netlify.app/v0.21.1/) - feat: delete website by
[@&#8203;btlghrants](https://togithub.com/btlghrants) in
[defenseunicorns/pepr#459

Locking down the Pepr generated Kubernetes manifests with
securityContexts - feat: add sane defaults to the pod and containers in
pepr deployments by [@&#8203;cmwylie19](https://togithub.com/cmwylie19)
in
[defenseunicorns/pepr#445

`npx pepr deploy --force` to override manager field in the underlying
KFC implementation of [Server Side
Apply](https://kubernetes.io/docs/reference/using-api/server-side-apply/#conflicts)
eat: force option on npx pepr deploy by
[@&#8203;cmwylie19](https://togithub.com/cmwylie19) in
[defenseunicorns/pepr#480

(e2e style) Upgrade test of Kubernetes manifests - feat: pepr upgrade
test by [@&#8203;cmwylie19](https://togithub.com/cmwylie19) in
[defenseunicorns/pepr#478

Force rollouts to Pepr's Admission and Watcher deployments by adding an
annotation to podSpecs - feat: add timestamp to podSpec annotations
force rollout on deployments by
[@&#8203;cmwylie19](https://togithub.com/cmwylie19) in
[defenseunicorns/pepr#483

#### What's Changed

- chore: update waitForDeployments by
[@&#8203;cmwylie19](https://togithub.com/cmwylie19) in
[defenseunicorns/pepr#482
- chore: add error message for easier debugging by
[@&#8203;cmwylie19](https://togithub.com/cmwylie19) in
[defenseunicorns/pepr#479
- chore: kubernetes slack channel for pepr and readme updates by
[@&#8203;cmwylie19](https://togithub.com/cmwylie19) in
[defenseunicorns/pepr#467
- chore: test code coverage by
[@&#8203;cmwylie19](https://togithub.com/cmwylie19) in
[defenseunicorns/pepr#468
- chore: bump the development-dependencies group with 2 updates by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[defenseunicorns/pepr#456
- chore: bump actions/dependency-review-action from 3.1.4 to 3.1.5 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[defenseunicorns/pepr#458
- chore: bump the development-dependencies group with 2 updates by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[defenseunicorns/pepr#457
- chore: bump the development-dependencies group with 1 update by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[defenseunicorns/pepr#466
- chore: bump the development-dependencies group with 1 update by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[defenseunicorns/pepr#469
- chore: bump actions/checkout from 2 to 4 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[defenseunicorns/pepr#472
- chore: bump actions/setup-node from 2 to 4 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[defenseunicorns/pepr#470
- chore: bump codecov/codecov-action from 2 to 3 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[defenseunicorns/pepr#471
- chore: bump the development-dependencies group with 1 update by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[defenseunicorns/pepr#475

**Full Changelog**:
defenseunicorns/pepr@v0.21.1...v0.22.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/defenseunicorns/uds-core).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMjcuMCIsInVwZGF0ZWRJblZlciI6IjM3LjEyNy4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
robmcelvenny pushed a commit to owen-grady/uds-core-slim-dev that referenced this pull request Jun 3, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [pepr](https://togithub.com/defenseunicorns/pepr) | [`0.21.1` ->
`0.22.0`](https://renovatebot.com/diffs/npm/pepr/0.21.1/0.22.0) |
[![age](https://developer.mend.io/api/mc/badges/age/npm/pepr/0.22.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/pepr/0.22.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/pepr/0.21.1/0.22.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/pepr/0.21.1/0.22.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>defenseunicorns/pepr (pepr)</summary>

###
[`v0.22.0`](https://togithub.com/defenseunicorns/pepr/releases/tag/v0.22.0)

[Compare
Source](https://togithub.com/defenseunicorns/pepr/compare/v0.21.1...v0.22.0)

#### Features

Make `npx pepr deploy` wait recursively for deployments to be in a
ready-state - feat: npx pepr dev does not wait for resources to be fully
up by [@&#8203;schaeferka](https://togithub.com/schaeferka) in
[defenseunicorns/pepr#435

Work on multi-versioned docs automation for the [Docs
Site](https://pepr-docs.netlify.app/v0.21.1/) - feat: delete website by
[@&#8203;btlghrants](https://togithub.com/btlghrants) in
[defenseunicorns/pepr#459

Locking down the Pepr generated Kubernetes manifests with
securityContexts - feat: add sane defaults to the pod and containers in
pepr deployments by [@&#8203;cmwylie19](https://togithub.com/cmwylie19)
in
[defenseunicorns/pepr#445

`npx pepr deploy --force` to override manager field in the underlying
KFC implementation of [Server Side
Apply](https://kubernetes.io/docs/reference/using-api/server-side-apply/#conflicts)
eat: force option on npx pepr deploy by
[@&#8203;cmwylie19](https://togithub.com/cmwylie19) in
[defenseunicorns/pepr#480

(e2e style) Upgrade test of Kubernetes manifests - feat: pepr upgrade
test by [@&#8203;cmwylie19](https://togithub.com/cmwylie19) in
[defenseunicorns/pepr#478

Force rollouts to Pepr's Admission and Watcher deployments by adding an
annotation to podSpecs - feat: add timestamp to podSpec annotations
force rollout on deployments by
[@&#8203;cmwylie19](https://togithub.com/cmwylie19) in
[defenseunicorns/pepr#483

#### What's Changed

- chore: update waitForDeployments by
[@&#8203;cmwylie19](https://togithub.com/cmwylie19) in
[defenseunicorns/pepr#482
- chore: add error message for easier debugging by
[@&#8203;cmwylie19](https://togithub.com/cmwylie19) in
[defenseunicorns/pepr#479
- chore: kubernetes slack channel for pepr and readme updates by
[@&#8203;cmwylie19](https://togithub.com/cmwylie19) in
[defenseunicorns/pepr#467
- chore: test code coverage by
[@&#8203;cmwylie19](https://togithub.com/cmwylie19) in
[defenseunicorns/pepr#468
- chore: bump the development-dependencies group with 2 updates by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[defenseunicorns/pepr#456
- chore: bump actions/dependency-review-action from 3.1.4 to 3.1.5 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[defenseunicorns/pepr#458
- chore: bump the development-dependencies group with 2 updates by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[defenseunicorns/pepr#457
- chore: bump the development-dependencies group with 1 update by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[defenseunicorns/pepr#466
- chore: bump the development-dependencies group with 1 update by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[defenseunicorns/pepr#469
- chore: bump actions/checkout from 2 to 4 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[defenseunicorns/pepr#472
- chore: bump actions/setup-node from 2 to 4 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[defenseunicorns/pepr#470
- chore: bump codecov/codecov-action from 2 to 3 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[defenseunicorns/pepr#471
- chore: bump the development-dependencies group with 1 update by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[defenseunicorns/pepr#475

**Full Changelog**:
defenseunicorns/pepr@v0.21.1...v0.22.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/defenseunicorns/uds-core).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMjcuMCIsInVwZGF0ZWRJblZlciI6IjM3LjEyNy4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Upgrading a pepr capability with no changes puts webhooks in nonfunctional state
3 participants