chore: npx pepr dev does not wait for resources to be fully up #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pepr-docs canceled.
|
cmwylie19
requested changes
Dec 11, 2023
cmwylie19
reviewed
Dec 13, 2023
cmwylie19
reviewed
Dec 13, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #435 +/- ##
=======================================
Coverage ? 83.21%
=======================================
Files ? 23
Lines ? 727
Branches ? 123
=======================================
Hits ? 605
Misses ? 114
Partials ? 8
Flags with carried forward coverage won't be shown. Click here to find out more. |
cmwylie19
approved these changes
Jan 11, 2024
cmwylie19
deleted the
419-npx-pepr-dev-does-not-wait-for-resources-to-be-fully-up
branch
jeff-mccoy
referenced
this pull request
in defenseunicorns/uds-core
Jan 13, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [pepr](https://togithub.com/defenseunicorns/pepr) | [`0.21.1` -> `0.22.0`](https://renovatebot.com/diffs/npm/pepr/0.21.1/0.22.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>defenseunicorns/pepr (pepr)</summary> ### [`v0.22.0`](https://togithub.com/defenseunicorns/pepr/releases/tag/v0.22.0) [Compare Source](https://togithub.com/defenseunicorns/pepr/compare/v0.21.1...v0.22.0) #### Features Make `npx pepr deploy` wait recursively for deployments to be in a ready-state - feat: npx pepr dev does not wait for resources to be fully up by [@​schaeferka](https://togithub.com/schaeferka) in [https://github.com/defenseunicorns/pepr/pull/435](https://togithub.com/defenseunicorns/pepr/pull/435) Work on multi-versioned docs automation for the [Docs Site](https://pepr-docs.netlify.app/v0.21.1/) - feat: delete website by [@​btlghrants](https://togithub.com/btlghrants) in [https://github.com/defenseunicorns/pepr/pull/459](https://togithub.com/defenseunicorns/pepr/pull/459) Locking down the Pepr generated Kubernetes manifests with securityContexts - feat: add sane defaults to the pod and containers in pepr deployments by [@​cmwylie19](https://togithub.com/cmwylie19) in [https://github.com/defenseunicorns/pepr/pull/445](https://togithub.com/defenseunicorns/pepr/pull/445) `npx pepr deploy --force` to override manager field in the underlying KFC implementation of [Server Side Apply](https://kubernetes.io/docs/reference/using-api/server-side-apply/#conflicts) eat: force option on npx pepr deploy by [@​cmwylie19](https://togithub.com/cmwylie19) in [https://github.com/defenseunicorns/pepr/pull/480](https://togithub.com/defenseunicorns/pepr/pull/480) (e2e style) Upgrade test of Kubernetes manifests - feat: pepr upgrade test by [@​cmwylie19](https://togithub.com/cmwylie19) in [https://github.com/defenseunicorns/pepr/pull/478](https://togithub.com/defenseunicorns/pepr/pull/478) Force rollouts to Pepr's Admission and Watcher deployments by adding an annotation to podSpecs - feat: add timestamp to podSpec annotations force rollout on deployments by [@​cmwylie19](https://togithub.com/cmwylie19) in [https://github.com/defenseunicorns/pepr/pull/483](https://togithub.com/defenseunicorns/pepr/pull/483) #### What's Changed - chore: update waitForDeployments by [@​cmwylie19](https://togithub.com/cmwylie19) in [https://github.com/defenseunicorns/pepr/pull/482](https://togithub.com/defenseunicorns/pepr/pull/482) - chore: add error message for easier debugging by [@​cmwylie19](https://togithub.com/cmwylie19) in [https://github.com/defenseunicorns/pepr/pull/479](https://togithub.com/defenseunicorns/pepr/pull/479) - chore: kubernetes slack channel for pepr and readme updates by [@​cmwylie19](https://togithub.com/cmwylie19) in [https://github.com/defenseunicorns/pepr/pull/467](https://togithub.com/defenseunicorns/pepr/pull/467) - chore: test code coverage by [@​cmwylie19](https://togithub.com/cmwylie19) in [https://github.com/defenseunicorns/pepr/pull/468](https://togithub.com/defenseunicorns/pepr/pull/468) - chore: bump the development-dependencies group with 2 updates by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/defenseunicorns/pepr/pull/456](https://togithub.com/defenseunicorns/pepr/pull/456) - chore: bump actions/dependency-review-action from 3.1.4 to 3.1.5 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/defenseunicorns/pepr/pull/458](https://togithub.com/defenseunicorns/pepr/pull/458) - chore: bump the development-dependencies group with 2 updates by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/defenseunicorns/pepr/pull/457](https://togithub.com/defenseunicorns/pepr/pull/457) - chore: bump the development-dependencies group with 1 update by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/defenseunicorns/pepr/pull/466](https://togithub.com/defenseunicorns/pepr/pull/466) - chore: bump the development-dependencies group with 1 update by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/defenseunicorns/pepr/pull/469](https://togithub.com/defenseunicorns/pepr/pull/469) - chore: bump actions/checkout from 2 to 4 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/defenseunicorns/pepr/pull/472](https://togithub.com/defenseunicorns/pepr/pull/472) - chore: bump actions/setup-node from 2 to 4 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/defenseunicorns/pepr/pull/470](https://togithub.com/defenseunicorns/pepr/pull/470) - chore: bump codecov/codecov-action from 2 to 3 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/defenseunicorns/pepr/pull/471](https://togithub.com/defenseunicorns/pepr/pull/471) - chore: bump the development-dependencies group with 1 update by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/defenseunicorns/pepr/pull/475](https://togithub.com/defenseunicorns/pepr/pull/475) **Full Changelog**: defenseunicorns/pepr@v0.21.1...v0.22.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/defenseunicorns/uds-core). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMjcuMCIsInVwZGF0ZWRJblZlciI6IjM3LjEyNy4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
robmcelvenny
referenced
this pull request
in owen-grady/uds-core-slim-dev
Jun 3, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [pepr](https://togithub.com/defenseunicorns/pepr) | [`0.21.1` -> `0.22.0`](https://renovatebot.com/diffs/npm/pepr/0.21.1/0.22.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>defenseunicorns/pepr (pepr)</summary> ### [`v0.22.0`](https://togithub.com/defenseunicorns/pepr/releases/tag/v0.22.0) [Compare Source](https://togithub.com/defenseunicorns/pepr/compare/v0.21.1...v0.22.0) #### Features Make `npx pepr deploy` wait recursively for deployments to be in a ready-state - feat: npx pepr dev does not wait for resources to be fully up by [@​schaeferka](https://togithub.com/schaeferka) in [https://github.com/defenseunicorns/pepr/pull/435](https://togithub.com/defenseunicorns/pepr/pull/435) Work on multi-versioned docs automation for the [Docs Site](https://pepr-docs.netlify.app/v0.21.1/) - feat: delete website by [@​btlghrants](https://togithub.com/btlghrants) in [https://github.com/defenseunicorns/pepr/pull/459](https://togithub.com/defenseunicorns/pepr/pull/459) Locking down the Pepr generated Kubernetes manifests with securityContexts - feat: add sane defaults to the pod and containers in pepr deployments by [@​cmwylie19](https://togithub.com/cmwylie19) in [https://github.com/defenseunicorns/pepr/pull/445](https://togithub.com/defenseunicorns/pepr/pull/445) `npx pepr deploy --force` to override manager field in the underlying KFC implementation of [Server Side Apply](https://kubernetes.io/docs/reference/using-api/server-side-apply/#conflicts) eat: force option on npx pepr deploy by [@​cmwylie19](https://togithub.com/cmwylie19) in [https://github.com/defenseunicorns/pepr/pull/480](https://togithub.com/defenseunicorns/pepr/pull/480) (e2e style) Upgrade test of Kubernetes manifests - feat: pepr upgrade test by [@​cmwylie19](https://togithub.com/cmwylie19) in [https://github.com/defenseunicorns/pepr/pull/478](https://togithub.com/defenseunicorns/pepr/pull/478) Force rollouts to Pepr's Admission and Watcher deployments by adding an annotation to podSpecs - feat: add timestamp to podSpec annotations force rollout on deployments by [@​cmwylie19](https://togithub.com/cmwylie19) in [https://github.com/defenseunicorns/pepr/pull/483](https://togithub.com/defenseunicorns/pepr/pull/483) #### What's Changed - chore: update waitForDeployments by [@​cmwylie19](https://togithub.com/cmwylie19) in [https://github.com/defenseunicorns/pepr/pull/482](https://togithub.com/defenseunicorns/pepr/pull/482) - chore: add error message for easier debugging by [@​cmwylie19](https://togithub.com/cmwylie19) in [https://github.com/defenseunicorns/pepr/pull/479](https://togithub.com/defenseunicorns/pepr/pull/479) - chore: kubernetes slack channel for pepr and readme updates by [@​cmwylie19](https://togithub.com/cmwylie19) in [https://github.com/defenseunicorns/pepr/pull/467](https://togithub.com/defenseunicorns/pepr/pull/467) - chore: test code coverage by [@​cmwylie19](https://togithub.com/cmwylie19) in [https://github.com/defenseunicorns/pepr/pull/468](https://togithub.com/defenseunicorns/pepr/pull/468) - chore: bump the development-dependencies group with 2 updates by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/defenseunicorns/pepr/pull/456](https://togithub.com/defenseunicorns/pepr/pull/456) - chore: bump actions/dependency-review-action from 3.1.4 to 3.1.5 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/defenseunicorns/pepr/pull/458](https://togithub.com/defenseunicorns/pepr/pull/458) - chore: bump the development-dependencies group with 2 updates by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/defenseunicorns/pepr/pull/457](https://togithub.com/defenseunicorns/pepr/pull/457) - chore: bump the development-dependencies group with 1 update by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/defenseunicorns/pepr/pull/466](https://togithub.com/defenseunicorns/pepr/pull/466) - chore: bump the development-dependencies group with 1 update by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/defenseunicorns/pepr/pull/469](https://togithub.com/defenseunicorns/pepr/pull/469) - chore: bump actions/checkout from 2 to 4 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/defenseunicorns/pepr/pull/472](https://togithub.com/defenseunicorns/pepr/pull/472) - chore: bump actions/setup-node from 2 to 4 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/defenseunicorns/pepr/pull/470](https://togithub.com/defenseunicorns/pepr/pull/470) - chore: bump codecov/codecov-action from 2 to 3 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/defenseunicorns/pepr/pull/471](https://togithub.com/defenseunicorns/pepr/pull/471) - chore: bump the development-dependencies group with 1 update by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/defenseunicorns/pepr/pull/475](https://togithub.com/defenseunicorns/pepr/pull/475) **Full Changelog**: defenseunicorns/pepr@v0.21.1...v0.22.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/defenseunicorns/uds-core). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMjcuMCIsInVwZGF0ZWRJblZlciI6IjM3LjEyNy4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
npx pepr deploy does not wait for resources to be fully up. Added wait to cli/deploy.ts so that it will not continue until all replicas are up.
Related Issue
Fixes #419
Type of change
Checklist before merging