Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle errors better in the Zarf agent #2672

Open
AustinAbro321 opened this issue Jun 27, 2024 · 0 comments
Open

Handle errors better in the Zarf agent #2672

AustinAbro321 opened this issue Jun 27, 2024 · 0 comments
Labels
tech-debt 💳 Debt that the team has charged and needs to repay

Comments

@AustinAbro321
Copy link
Contributor

Describe what should be investigated or refactored

Currently we return 500 errors or we warn and continue within the Zarf agent when there are errors. In most, if not all, of this situations we should instead return 400 errors (bad request) as usually the issue is that there is bad data being sent to the agent.

Things to consider:

  • How does this change the user experience ? Does it make it harder to see errors, if so, maybe we should reconsider this change
  • This will affect pods with containers that don't get mutated? Do we think this is significant enough to warrant a breaking change or a wait for GA?

Links to any relevant code

There are more examples but this is a few

@AustinAbro321 AustinAbro321 added the tech-debt 💳 Debt that the team has charged and needs to repay label Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tech-debt 💳 Debt that the team has charged and needs to repay
Projects
Status: Triage
Development

No branches or pull requests

1 participant