-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Big Bang Core Example #29
Conversation
I think we should have all big bang-specific stuff in that example folder, including the vagrantfile, is that doable? |
I thought about that, but it would mean doing a different make target, which felt less user friendly. I don't have a strong opinion either way. |
mind if I play with it a little? |
Nope, go for it. |
Thanks for working this @RothAndrew and getting it close to the finish line, I couldn't get it to work, but it's close. Few observations I think we need to think through some more:
Okay that's a lot, I'm going to push my changes here, feel free to throw flaming darts my way when you get back online. |
It's probably also worth discussing the use if interal K8s routes for git and |
TL/DR: Looks good, couple of tweaks and a bit more testing on my end then let's merge.
Works for me. I'll work on that here in a few minutes.
I was having a hard time getting it to work, but it may have been the
I didn't think about needing root for <1024. The screenshots were showing services exposed by Istio, which is running on 8443. I can change it to forward Traefik to 8080/8443 and Istio to 9080/9443. So, to hit Gitea you'll go to https://localhost:8443, to hit one of the services exposed by Istio, you'll go to https://*.bigbang.dev:9443. The way it is now in examples/Vagrantfile won't expose any of the Istio-exposed services at all, just the Traefik stuff.
I wouldn't worry too much about it. It feels like it is taking the same amount of time as any other BB deployment.
Works for me. It might need some tweaking for ease of use but it works for now.
Agreed. |
Copy all thanks. Sounds like the only outstanding work now is the port mapping, I’ll leave it up to you, but we do need ports above 1024. This is fantastic work @RothAndrew. 🦄 |
Thanks! Working on it today between meetings. |
I'm happy, think we're ready to merge. |
# Conflicts: # assets/misc/registries.yaml
Moving back to Draft for right now until after my demo today. I fixed the tiny-kafka example but it should go in its own PR |
Created #43 to address this later |
This reverts commit f831fcf.
Pulled out the tiny-kafka example fix, ready for merge again |
# Conflicts: # Vagrantfile # examples/Makefile
@jeff-mccoy do you have any objections to merging this now? It's starting to get a little long in the tooth |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, great work
Signed-off-by: Jeff McCoy <code@jeffm.us>
Signed-off-by: Jeff McCoy <code@jeffm.us>
Note: I'm mostly using this branch to learn how to use Zarf. Some of what is here may not be appropriate to merge into the trunk.No way man, we're doing this for realz!Objectives
What/Why
bigbangdemo
that provisions more CPU, more memory, and more drive space. Other VM targets should be mostly unaffected, except for:registries.yaml
that will get placed in/etc/rancher/k3s/registries.yaml
so that K3s will automatically usezarf.localhost
as a registry mirror. I'm not quite as sure about this approach. It was definitely needed for my BB demo but I'm not sure whether it is appropriate to put it in the Zarf Init package like it is. Feel free to 💩 on it!Add .editorconfig fileMoved to separate PR Add .editorconfig #37Followup
Closes #8