Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

function WriteOptimistic in Stream.h has a void return type #52

Closed
sarahelghandour opened this issue Nov 5, 2021 · 3 comments
Closed

Comments

@sarahelghandour
Copy link

Hi,

I think the below function in Stream.h should have the type bool not void.

Regards,
Sarah

void WriteOptimistic(T const &val) {
#pragma HLS INLINE
#ifndef HLSLIB_SYNTHESIS
#pragma HLS INLINE
return WriteOptimistic(val, depth_);
#else
return WriteOptimistic(val, std::numeric_limits::max());
#endif
}

@definelicht
Copy link
Owner

Hi, maybe you're thinking of the non-blocking version of write, which is called WriteNonBlocking? Or why would you expect a boolean return type?

@sarahelghandour
Copy link
Author

Oh sorry, I think I didn't grasp the code properly yet. Sorry for the confusion.

@definelicht
Copy link
Owner

No worries

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants