Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose sprite scaling in editor (DEFEDIT-1051) #3981

Closed
britzl opened this issue May 27, 2019 · 0 comments · Fixed by #6865
Closed

Expose sprite scaling in editor (DEFEDIT-1051) #3981

britzl opened this issue May 27, 2019 · 0 comments · Fixed by #6865
Assignees
Labels
editor Issues related to the Defold editor feature request A suggestion for a new feature

Comments

@britzl
Copy link
Contributor

britzl commented May 27, 2019

Currently, sprite scale can be modified in runtime only (go.set("#sprite", "scale", vmath.vector3(...)). It would be very nice if scale could be set in the editor as well.

(forum request: (LINK REMOVED)
2017-08-07 11:42:22 (Mats.Gisselson)
What we really want to do is to move the Scale properties from the components that have it up to the ComponentInstance where the Position and Rotation properties already reside.

  • Investigate how much work it would be to move the Scale property to the ComponentInstance (engine, bob).

If this is not too much work, it might be worth doing before exposing Scale in the editors.

An alternative approach is to simply expose the Scale property on embedded Sprites and Labels, and hide it on Resources.

  • Not a lot of work in Editor 2.
  • Should do this in Editor 1 as well. Difficult?
  • No change in Bob or the file formats.
  • Scale property was never hidden for Label resources - Possibly write instructions for how to fix it using the References function in Editor 2 instead of performing a cross-file migration?

If we later decide to move the Scale property to the ComponentInstance, we need to update both editors to perform a simple migration on load. Bob also needs to be patched to read the Scale property from the old place if not present in the ComponentInstance.

@britzl britzl added bug Something is not working as expected editor Issues related to the Defold editor feature request A suggestion for a new feature and removed bug Something is not working as expected labels May 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editor Issues related to the Defold editor feature request A suggestion for a new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants