Download symbols in vanilla builds if --with-symbols is used #5412
Conversation
| variantSuffix = "_release"; | ||
| break; | ||
| case Bob.VARIANT_HEADLESS: | ||
| variantSuffix = "_release"; |
| int code = connection.getResponseCode(); | ||
|
|
||
| if (code == 304) { | ||
| logInfo("Status %d: Already cached", code); |
There was a problem hiding this comment.
What happens if the output folder is removed between the downloads?
It's not uncommon to clean the build folder for instance (or .internal/cache)
There was a problem hiding this comment.
Not sure I understand the scenario you describe. Should we download the vanilla symbols later in the build process you mean?
There was a problem hiding this comment.
What I mean is, what would happen if you get a 304, but the target file doesn't exist? (e.g. because the build folder was removed between runs)
There was a problem hiding this comment.
Ah, got it. Yes, that's a problem.
There was a problem hiding this comment.
But we don't really handle that very well when resolving libs either.
There was a problem hiding this comment.
Now that I think of it I don't believe the server can respond with a 304 since I do not include any request headers indicating ETag or Last-Modified.
There was a problem hiding this comment.
Then I guess you shouldn't handle it here either, since if one would start to send the Etag, this code would fail.
| @@ -76,6 +76,7 @@ private void printProgress() { | |||
|
|
|||
| @Override | |||
| public void beginTask(String name, int work) { | |||
| System.out.print(name); | |||
There was a problem hiding this comment.
Debug prints?
Won't this spam the console for all resources being built in a project?
If so, it should probably be configurable, and also be done via a logger (where we can format the output)
There was a problem hiding this comment.
Isn't beginTask() only used for the main high level build steps such as "Building", "Bundling", "Cleaning" etc?
There was a problem hiding this comment.
Not sure. But if it's so, then It might probably look fine.
We really need to look into logging overall, since it's spotty at best, and also uses different logging techniques (which we cannot currently switch on or off)
There was a problem hiding this comment.
I agree. We should use Log4j or similar.
| int code = connection.getResponseCode(); | ||
|
|
||
| if (code == 304) { | ||
| logInfo("Status %d: Already cached", code); |
There was a problem hiding this comment.
What I mean is, what would happen if you get a 304, but the target file doesn't exist? (e.g. because the build folder was removed between runs)
…5412) * Download symbols in vanilla builds if --with-symbols is used * Review fix. Typo.
Fixes #5199