Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTML5: FileLoader doesn't call callbacks on retry #5762

Merged
merged 1 commit into from
Apr 21, 2021
Merged

HTML5: FileLoader doesn't call callbacks on retry #5762

merged 1 commit into from
Apr 21, 2021

Conversation

aglitchman
Copy link
Contributor

@aglitchman aglitchman commented Apr 21, 2021 •
edited
Loading

I would love to see this fix in the Defold 1.2.182 BETA, if it's possible.

dmloader.js FileLoader doesn't call callbacks on retry because setTimeout set this to window object, the original object is lost. This PR fixes it.

image

@britzl britzl self-requested a review April 21, 2021 10:37
britzl
britzl approved these changes Apr 21, 2021
View reviewed changes
Copy link
Contributor

@britzl britzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch! I wasn't familiar with the bind() function.

@britzl britzl merged commit d6e7e82 into defold:dev Apr 21, 2021
britzl pushed a commit that referenced this pull request Apr 21, 2021
@aglitchman @britzl
Update dmloader.js to fix callbacks calls on retry (#5762)
f1a2280
@britzl britzl added bug Something is not working as expected html5 Issue related to the HTML5 platform labels Apr 21, 2021
@britzl
Copy link
Contributor

britzl commented Apr 21, 2021

Merged and cherry picked to the beta

pull bot pushed a commit to proteanblank/defold that referenced this pull request Jul 28, 2021
@aglitchman
Update dmloader.js to fix callbacks calls on retry (defold#5762)
966a24f
pull bot pushed a commit to proteanblank/defold that referenced this pull request Jul 28, 2021
@aglitchman @britzl
Update dmloader.js to fix callbacks calls on retry (defold#5762)
7d5fab4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@britzl britzl britzl approved these changes

Assignees
No one assigned
Labels
bug Something is not working as expected html5 Issue related to the HTML5 platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aglitchman @britzl