Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch exception when xml fails to load #5962

Merged
merged 2 commits into from
Sep 6, 2021

Conversation

britzl
Copy link
Contributor

@britzl britzl commented Aug 2, 2021

Fixes #5533

@britzl britzl requested a review from JCash August 2, 2021 14:19
@britzl britzl marked this pull request as draft August 3, 2021 08:27
@britzl britzl marked this pull request as ready for review August 20, 2021 10:35
(with-open [stream (io/input-stream (io/resource path))]
(xml/parse stream)))
(defn- empty-svg []
{:tag :svg, :attrs nil, :content [{ :tag :path, :attrs {:d "M0,0"}, :content nil}]})
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the bare minimum structure of an empty parsed SVG file.

@britzl britzl linked an issue Aug 23, 2021 that may be closed by this pull request
@britzl britzl merged commit 761562b into editor-dev Sep 6, 2021
@britzl britzl deleted the DEFEDIT-5533-Crash-when-loading-svg branch September 6, 2021 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash when opening Template tab of Welcome screen
2 participants