Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignored files in .defignore still processed by the editor #6400

Closed
AGulev opened this issue Feb 13, 2022 · 0 comments · Fixed by #6779
Closed

Ignored files in .defignore still processed by the editor #6400

AGulev opened this issue Feb 13, 2022 · 0 comments · Fixed by #6779
Assignees
@vlaaad
Labels
bug Something is not working as expected editor Issues related to the Defold editor
Projects
Editor Backlog 1.3.5

Comments

@AGulev
Copy link
Contributor

AGulev commented Feb 13, 2022

Describe the bug (REQUIRED)
Even if a resource added in the .defignore file, the editor still process it.

To Reproduce (REQUIRED)
Steps to reproduce the behavior:

  1. Open the attached test project
  2. Make sure 2.atlas file is in .defignore
  3. Open the same file in an external editor
  4. Remove one image from this atlas
  5. Switch back to the editor
  6. Changes takes longer than switching back without any changes.

Expected behavior (REQUIRED)
Atlas should be ignored.

Defold version (REQUIRED):

  • Version 1.2.193 alpha

Platforms (REQUIRED):

  • Platforms: macos
  • OS: macos

Minimal repro case project (OPTIONAL):
Uploading ignore-repo.zip…
@AGulev AGulev added bug Something is not working as expected editor Issues related to the Defold editor labels Feb 13, 2022
@britzl britzl added this to To Do in Editor Backlog via automation Mar 24, 2022
@AGulev AGulev closed this as completed May 30, 2022
Editor Backlog automation moved this from To Do to Done May 30, 2022
@AGulev AGulev reopened this May 31, 2022
@britzl britzl added this to To do in 1.3.5 via automation Jun 22, 2022
@britzl britzl moved this from To do to In progress in 1.3.5 Jul 4, 2022
vlaaad added a commit that referenced this issue Jul 6, 2022
@vlaaad
Report defignored files as non-existent
1dc3edd 
Additionally, this changeset makes the editor sync resources after save if `.defignore` file was modified.

Fixes #6400
@vlaaad vlaaad mentioned this issue Jul 6, 2022
Merged
@britzl britzl linked a pull request Jul 7, 2022 that will close this issue
Report defignored files as non-existent #6779
Merged
@britzl britzl closed this as completed Jul 7, 2022
1.3.5 automation moved this from In progress to Done Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vlaaad vlaaad

Labels
bug Something is not working as expected editor Issues related to the Defold editor
Projects
Editor Backlog
Done
1.3.5
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Report defignored files as non-existent defold/defold
3 participants
@vlaaad @britzl @AGulev