Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve resource sync performance in large projects #8595

Closed
vlaaad opened this issue Feb 26, 2024 · 0 comments
Closed

Improve resource sync performance in large projects #8595

vlaaad opened this issue Feb 26, 2024 · 0 comments
Assignees
@vlaaad
Labels
editor Issues related to the Defold editor task A task that needs to be performed

Comments

@vlaaad
Copy link
Contributor

vlaaad commented Feb 26, 2024

Task (REQUIRED):
File.getCanonicalPath and File.lastModified in defignore-pred take a huge chunk (30%!) of resource sync time, we should not touch the file system every time we check .defignore:
Screenshot 2024-02-26 at 11 11 17
It should be also possible to improve the performance of resource sync data structure building (resource-paths), which currently builds temporary sets where it might be faster to diff maps directly:
Screenshot 2024-02-26 at 11 12 32

Expected outcome (REQUIRED):
The resource sync is noticeably faster in large projects.
@vlaaad vlaaad added task A task that needs to be performed editor Issues related to the Defold editor labels Feb 26, 2024
vlaaad added a commit that referenced this issue Mar 13, 2024
@vlaaad
Improve resource sync performance
b60aa3b 
Fixes #8595
@vlaaad vlaaad mentioned this issue Mar 13, 2024
Merged
@vlaaad vlaaad self-assigned this Mar 14, 2024
vlaaad added a commit that referenced this issue Mar 25, 2024
@vlaaad
Improve resource sync performance (#8674)
2d6a359 
* Improve resource sync performance

Fixes #8595

* Bring back the misspelling
vlaaad added a commit that referenced this issue Mar 25, 2024
@vlaaad
Improve resource sync performance (#8674)
879a6fd 
* Improve resource sync performance

Fixes #8595

* Bring back the misspelling
@vlaaad vlaaad mentioned this issue Mar 25, 2024
Merged
vlaaad added a commit that referenced this issue Mar 25, 2024
@vlaaad
Improve resource sync performance (#8674) (#8704)
b108630 
* Improve resource sync performance

Fixes #8595

* Bring back the misspelling
@vlaaad vlaaad closed this as completed Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vlaaad vlaaad

Labels
editor Issues related to the Defold editor task A task that needs to be performed
Projects
No open projects
1.8.0
Status: Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vlaaad