Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash when changing sprite atlas and sprite has an invalid animation #7550

Merged
merged 2 commits into from Apr 5, 2023
Merged

Fix crash when changing sprite atlas and sprite has an invalid animation #7550

merged 2 commits into from Apr 5, 2023

Conversation

AGulev
Copy link
Contributor

@AGulev AGulev commented Apr 5, 2023 •
edited

Fix crash when set new atlas which has more animations than the old one but without animation with the same name which currently playing.

Fix #7445

PR checklist

  • Code
    • Add engine and/or editor unit tests.
    • New and changed code follows the overall code style of existing code
    • Add comments where needed
  • Documentation
    • Make sure that API documentation is updated in code comments
    • Make sure that manuals are updated (in github.com/defold/doc)
  • Prepare pull request and affected issue for automatic release notes generator
    • Pull request - Write a message that explains what this pull request does. What was the problem? How was it solved? What are the changes to APIs or the new APIs introduced? This message will be used in the generated release notes. Make sure it is well written and understandable for a user of Defold.
    • Pull request - Write a pull request title that in a sentence summarises what the pull request does. Do not include "Issue-1234 ..." in the title. This text will be used in the generated release notes.
    • Pull request - Link the pull request to the issue(s) it is closing. Use on of the approved closing keywords.
    • Affected issue - Assign the issue to a project. Do not assign the pull request to a project if there is an issue which the pull request closes.
    • Affected issue - Assign the "breaking change" label to the issue if introducing a breaking change.
    • Affected issue - Assign the "skip release notes" is the issue should not be included in the generated release notes.

@AGulev AGulev requested a review from britzl April 5, 2023 11:24
@AGulev AGulev requested a review from britzl April 5, 2023 11:49
@AGulev AGulev merged commit a809fb8 into dev Apr 5, 2023
20 checks passed
@AGulev AGulev deleted the issue-7445-crash branch April 5, 2023 12:59
Jhonnyg pushed a commit that referenced this pull request Apr 14, 2023
@AGulev @Jhonnyg
Fix crash when changing sprite atlas and sprite has an invalid animat…
d8ab687 
…ion (#7550)

* fix crash when new atlas has more animations that the old one but without animation with the same name

* restore ancidently removed line
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@britzl britzl britzl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Crash when changing sprite atlas and sprite has an invalid animation
2 participants
@AGulev @britzl