Don't replace all occurences of empty string #7791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The problem: when running `replace-all` with an empty string find term, the editor got stuck in an infinite loop finding next occurences. User-facing changes: the editor no longer locks up executing "Replace All" command in the code editor view when the search term is empty Fixes #7790
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem: when running
replace-allwith an empty string find term, the editor got stuck in an infinite loop finding the next occurrences.User-facing changes: the editor no longer locks up executing the "Replace All" command in the code editor view when the search term is empty
Fixes #7790