Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error about syncfs is now a warning message #7798

Merged
merged 2 commits into from Jul 13, 2023
Merged

Conversation

aglitchman
Copy link
Contributor

@aglitchman aglitchman commented Jul 13, 2023

This change will log a user friendly warning instead of an error in HTML5 builds if the mounted file system fails to sync.

Fixes #7797

PR checklist

  • Code
    • Add engine and/or editor unit tests.
    • New and changed code follows the overall code style of existing code
    • Add comments where needed
  • Documentation
    • Make sure that API documentation is updated in code comments
    • Make sure that manuals are updated (in github.com/defold/doc)
  • Prepare pull request and affected issue for automatic release notes generator
    • Pull request - Write a message that explains what this pull request does. What was the problem? How was it solved? What are the changes to APIs or the new APIs introduced? This message will be used in the generated release notes. Make sure it is well written and understandable for a user of Defold.
    • Pull request - Write a pull request title that in a sentence summarises what the pull request does. Do not include "Issue-1234 ..." in the title. This text will be used in the generated release notes.
    • Pull request - Link the pull request to the issue(s) it is closing. Use on of the approved closing keywords.
    • Affected issue - Assign the issue to a project. Do not assign the pull request to a project if there is an issue which the pull request closes.
    • Affected issue - Assign the "breaking change" label to the issue if introducing a breaking change.
    • Affected issue - Assign the "skip release notes" is the issue should not be included in the generated release notes.

I looked at the documentation https://emscripten.org/docs/api_reference/Filesystem-API.html and replaced `error` with `warn` in `dmloader.js`, and replaced the "error" text with a more understandable one.
@britzl britzl self-requested a review July 13, 2023 15:13
Copy link
Contributor

@britzl britzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! (I changed from "Can't" to "Unable to")

@britzl britzl merged commit ac8a96a into defold:dev Jul 13, 2023
1 check passed
@aglitchman
Copy link
Contributor Author

Thank you! (I changed from "Can't" to "Unable to")

Thanks! Much better 🙌🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HTML5: The error about syncfs should be a warning message
2 participants