Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue when CMD+H doesn't hide the editor on MacOS #7825

Merged
merged 3 commits into from Jul 24, 2023
Merged

Conversation

AGulev
Copy link
Contributor

@AGulev AGulev commented Jul 23, 2023

Fixed issue when CMD+Hon MacOS shows Java About window instead of application hiding.

Fix #7528

PR checklist

  • Code
    • Add engine and/or editor unit tests.
    • New and changed code follows the overall code style of existing code
    • Add comments where needed
  • Documentation
    • Make sure that API documentation is updated in code comments
    • Make sure that manuals are updated (in github.com/defold/doc)
  • Prepare pull request and affected issue for automatic release notes generator
    • Pull request - Write a message that explains what this pull request does. What was the problem? How was it solved? What are the changes to APIs or the new APIs introduced? This message will be used in the generated release notes. Make sure it is well written and understandable for a user of Defold.
    • Pull request - Write a pull request title that in a sentence summarises what the pull request does. Do not include "Issue-1234 ..." in the title. This text will be used in the generated release notes.
    • Pull request - Link the pull request to the issue(s) it is closing. Use on of the approved closing keywords.
    • Affected issue - Assign the issue to a project. Do not assign the pull request to a project if there is an issue which the pull request closes.
    • Affected issue - Assign the "breaking change" label to the issue if introducing a breaking change.
    • Affected issue - Assign the "skip release notes" is the issue should not be included in the generated release notes.

@AGulev AGulev requested a review from britzl July 23, 2023 18:49
clojure.java.io/resource..
*/

new BufferedImage(1, 1, BufferedImage.TYPE_3BYTE_BGR);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This old hack doesn't work anymore, but using of Desktop.getDesktop().setAboutHandler(null); helps and CMD+H works fine

@AGulev AGulev merged commit 3c74c03 into dev Jul 24, 2023
43 checks passed
@AGulev AGulev deleted the issue-7528 branch July 24, 2023 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't hide current window: M1 Mac Pro 14 MacOS 13.3 Defold 1.4.4
2 participants