Show notifications about fetch library issues #7868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
User-facing changes: The editor will now show notifications about failed attempts to fetch libraries. Fixes #4000
vlaaad
commented
Aug 7, 2023
Comment on lines
-238
to
-247
| (defn copy-engine-executable! ^File [^File target-dmengine platform {:keys [^File dmengine ^File engine-archive] :as engine-descriptor}] | ||
| (assert (or dmengine engine-archive)) | ||
| (cond | ||
| (some? dmengine) | ||
| (fs/copy-file! dmengine target-dmengine) | ||
|
|
||
| (some? engine-archive) | ||
| (unpack-dmengine! engine-archive (dmengine-filename platform) target-dmengine)) | ||
| target-dmengine) | ||
|
|
matgis
reviewed
Aug 14, 2023
| @@ -427,7 +427,8 @@ | |||
| Options: | |||
| :fail :silently will not throw an exception on failure, and instead return an empty vector. | |||
| :target :keep will not replace the target file if it exists. | |||
| :target :replace (default) will replace the target file if it exists." | |||
| :target :replace (default) will replace the target file if it exists. | |||
| Returns a vector of source+target pairs if successful" | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User-facing changes:
The editor will now show notifications about failed attempts to fetch libraries.
Fixes #4000