Zig syntax highlighting support in the editor #7888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matgis
changed the title
vlaaad
approved these changes
Aug 16, 2023
Comment on lines
+156
to
+157
| :indent {:begin #"^.*\{[^}\"\']*$|^.*\([^\)\"\']*$|^\s*\{\}$" | ||
| :end #"^\s*(\s*/[*].*[*]/\s*)*\}|^\s*(\s*/[*].*[*]/\s*)*\)"} |
There was a problem hiding this comment.
Hmm, how did you come up with those though? I haven't found anything about indentation in https://github.dev/ziglang/vscode-zig
There was a problem hiding this comment.
I used the indentation rules from the C-ish languages since Zig uses a similar brace structure.
Comment on lines
+24
to
+39
| ;; This is a simplified implementation of TextMate-style syntax highlighting | ||
| ;; that allows us to adopt rules from existing .tmLanguage files. At some point | ||
| ;; we might want to implement full support for TextMate grammars, since it has | ||
| ;; been widely adopted by modern text editors. To fully support them would take | ||
| ;; a bit of work. Here are a few useful resources that might help guide this | ||
| ;; effort in the future: | ||
| ;; | ||
| ;; Writing a TextMate Grammar: Some Lessons Learned | ||
| ;; https://www.apeth.com/nonblog/stories/textmatebundle.html | ||
| ;; | ||
| ;; The Language Grammars section from the TextMate manual | ||
| ;; https://macromates.com/manual/en/language_grammars | ||
| ;; | ||
| ;; The Indentation Rules section from the TextMate manual appendix | ||
| ;; https://macromates.com/manual/en/appendix#indentation_rules | ||
|
|
JCash
added a commit
that referenced
this pull request
Jun 6, 2024
…7889) * Initial extension C api * Fixed C api test for extension.h * Added initial Zig support to extender config * Moved dmExtensionDesc to public header so that Zig can allocate it. * fixes * Merge fixes * Added Zig syntax highlighting support in the editor (#7888) * Removed experimental enum macro * Added first test for cpp header generation * Updated generation script * Fixed compile errors and made the C functions the base implementation * Added support for enums * Updated extension.h to generate .hpp header * build fix for windows * test fix * win32 compile fix * Fixes to generator scripts * Updated resource system * Updated libs to use latest resource headers * Unified back into a single resource.h * Update documentation. Renamed some struct arguments to make them more consistent * review cleanup * html build fix * compile fix * Update the dmsdk with the hpp files * Added missing test data --------- Co-authored-by: Mats Gisselson <matgis@users.noreply.github.com>
AGulev
pushed a commit
that referenced
this pull request
Jun 25, 2024
…7889) * Initial extension C api * Fixed C api test for extension.h * Added initial Zig support to extender config * Moved dmExtensionDesc to public header so that Zig can allocate it. * fixes * Merge fixes * Added Zig syntax highlighting support in the editor (#7888) * Removed experimental enum macro * Added first test for cpp header generation * Updated generation script * Fixed compile errors and made the C functions the base implementation * Added support for enums * Updated extension.h to generate .hpp header * build fix for windows * test fix * win32 compile fix * Fixes to generator scripts * Updated resource system * Updated libs to use latest resource headers * Unified back into a single resource.h * Update documentation. Renamed some struct arguments to make them more consistent * review cleanup * html build fix * compile fix * Update the dmsdk with the hpp files * Added missing test data --------- Co-authored-by: Mats Gisselson <matgis@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User-facing changes