Fix issue when window (on Mac) opens without focus #7949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AGulev
commented
Sep 4, 2023
|
|
||
| // Having the app in front of the terminal window is also generally | ||
| // handy. There is an NSApplication API to do this, but... | ||
| SetFrontProcess( &psn ); |
There was a problem hiding this comment.
SetFrontProcess - deprecated
| // Eclipse does something similar: | ||
| // https://bugs.eclipse.org/bugs/attachment.cgi?id=248969 | ||
| [NSApp nextEventMatchingMask: NSAnyEventMask untilDate: nil | ||
| inMode: NSDefaultRunLoopMode dequeue: NO ]; |
There was a problem hiding this comment.
it seems like this hack doesn't work anymore. I moved part of it to didupdate event
| @@ -127,9 +127,17 @@ - (NSApplicationTerminateReply)applicationShouldTerminate:(NSApplication *)sende | |||
| return NSTerminateCancel; | |||
| } | |||
|
|
|||
| - (void)applicationDidFinishLaunching:(NSNotification *)notification | |||
| { | |||
| [[NSRunningApplication currentApplication] activateWithOptions:(NSApplicationActivateAllWindows | NSApplicationActivateIgnoringOtherApps)]; | |||
There was a problem hiding this comment.
this event never called
| if( !_glfwLibrary.Unbundled ) { | ||
| ProcessSerialNumber psn = { 0, kCurrentProcess }; | ||
| TransformProcessType( &psn, kProcessTransformToForegroundApplication ); | ||
| [[NSApplication sharedApplication] activateIgnoringOtherApps: YES]; |
There was a problem hiding this comment.
Recommended function instead of SetFrontProcess() even though it's deprecated as well 🤷♂️
| // Wait for the first update to make window active | ||
| // It helps to avoid issue when the window opens inactive | ||
| // https://github.com/defold/defold/issues/6709 | ||
| if( !_glfwLibrary.Unbundled ) { |
There was a problem hiding this comment.
just to make sure we call it once
| @@ -810,7 +817,6 @@ int _glfwPlatformOpenWindow( int width, int height, | |||
| } | |||
| _glfwWin.aux_context = [[NSOpenGLContext alloc] initWithFormat:_glfwWin.pixelFormat shareContext:_glfwWin.context]; | |||
|
|
|||
| [_glfwWin.window makeKeyAndOrderFront:nil]; | |||
There was a problem hiding this comment.
there is no reason to call it twice
britzl
approved these changes
Sep 4, 2023
This was referenced Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed an issue when a window on Mac opens without focus. In such cases, the window doesn't react to most input events, and only double-click works.
Fix #6709
PR checklist