Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toggle visibility of object using shortcut #8072

Merged
merged 2 commits into from Oct 3, 2023

Conversation

quangson91
Copy link
Contributor

@quangson91 quangson91 commented Oct 2, 2023

Support Ctrl + E to toggle show/hide objects.

Fixes #5476

Technical changes:

  • Remove show/hide-selected.
  • Add toggle-selected.
  • Context menu text become: Show/Hide Selected Objects

Video demo.
Change show/hide status by using shortcut & context menu.

2023-10-02.22-27-21.mp4

Signed-off-by: quangson91 <quangson91@gmail.com>
@CLAassistant
Copy link

CLAassistant commented Oct 2, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@matgis matgis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing to Defold! ❤️

I tested it, and it works well. I think we need to rename the :toggle-selected action, though, as it will likely end up as a key in a preferences dictionary sometime in the future, and it sounds a bit too generic.

Also, could I ask you to add Fixes defold/defold#5476 to the top of the PR description so we can track it? 🙂

editor/src/clj/editor/keymap.clj Outdated Show resolved Hide resolved
editor/src/clj/editor/scene_visibility.clj Outdated Show resolved Hide resolved
Signed-off-by: quangson91 <quangson91@gmail.com>
@quangson91 quangson91 requested a review from matgis October 3, 2023 08:43
Copy link
Contributor

@matgis matgis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@matgis matgis merged commit 0c7c089 into defold:dev Oct 3, 2023
1 check passed
@matgis
Copy link
Contributor

matgis commented Oct 3, 2023

Approved and merged! Thanks for contributing to Defold! ❤️

@quangson91 quangson91 deleted the 5476_toggle_show_hide branch October 3, 2023 09:23
@britzl
Copy link
Contributor

britzl commented Oct 3, 2023

Indeed, thank you for the contribution @quangson91 !

@AGulev AGulev changed the title #5476: Toggle visibility of object using shortcut Toggle visibility of object using shortcut Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Ctrl+E to show node if it already hidden
4 participants