Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new default filtering keyword for material samplers (Engine support) #8419

Merged
merged 4 commits into from Jan 19, 2024

Conversation

Jhonnyg
Copy link
Contributor

@Jhonnyg Jhonnyg commented Jan 17, 2024

This PR adds new filtering keyword for material samplers called:

FILTER_MODE_MIN_DEFAULT
FILTER_MODE_MAG_DEFAULT

When using these settings on a sampler in the material, the engine will pick the global min and mag settings that is specified in the game.project -> graphics setting. This can be useful for having a global base filtering method, while still being able to specialise settings per sampler if needed.

Fixes #8417

PR checklist

  • Code
    • Add engine and/or editor unit tests.
    • New and changed code follows the overall code style of existing code
    • Add comments where needed
  • Documentation
    • Make sure that API documentation is updated in code comments
    • Make sure that manuals are updated (in github.com/defold/doc)
  • Prepare pull request and affected issue for automatic release notes generator
    • Pull request - Write a message that explains what this pull request does. What was the problem? How was it solved? What are the changes to APIs or the new APIs introduced? This message will be used in the generated release notes. Make sure it is well written and understandable for a user of Defold.
    • Pull request - Write a pull request title that in a sentence summarises what the pull request does. Do not include "Issue-1234 ..." in the title. This text will be used in the generated release notes.
    • Pull request - Link the pull request to the issue(s) it is closing. Use on of the approved closing keywords.
    • Affected issue - Assign the issue to a project. Do not assign the pull request to a project if there is an issue which the pull request closes.
    • Affected issue - Assign the "breaking change" label to the issue if introducing a breaking change.
    • Affected issue - Assign the "skip release notes" is the issue should not be included in the generated release notes.

Example of a well written PR description:

  1. Start with the user facing changes. This will end up in the release notes.
  2. Add one of the GitHub approved closing keywords
  3. Optionally also add the technical changes made. This is information that might help the reviewer. It will not show up in the release notes. Technical changes are identified by a line starting with one of these:
    1. ### Technical changes
    2. Technical changes:
    3. Technical notes:
There was a anomaly in the carbon chroniton propeller, introduced in version 8.10.2. This fix will make sure to reset the phaser collector on application startup.

Fixes #1234

### Technical changes
* Pay special attention to line 23 of phaser_collector.clj as it contains some interesting optimizations
* The propeller code was not taking into account a negative phase.

@Jhonnyg Jhonnyg requested review from JCash and vlaaad January 17, 2024 17:25
@Jhonnyg Jhonnyg marked this pull request as ready for review January 17, 2024 18:21
JCash
JCash previously approved these changes Jan 19, 2024
Comment on lines 710 to 711
// Tests only:
void GetTextureFilters(HContext context, uint32_t unit, TextureFilter& min_filter, TextureFilter& mag_filter);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's local (graphics) tests, then I'd like to keep them in graphics_private.h to make it clearer and easier to keep the "public" headers free from it.

vlaaad
vlaaad previously approved these changes Jan 19, 2024
@Jhonnyg Jhonnyg dismissed stale reviews from vlaaad and JCash via 39eda37 January 19, 2024 14:38
@Jhonnyg Jhonnyg merged commit 36d8a0c into dev Jan 19, 2024
15 checks passed
@Jhonnyg Jhonnyg deleted the issue-8417-sampler-default-filter-engine branch January 19, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add "use_default" filter constant to material samplers
3 participants