Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clear the texture data if no buffer is passed in when using resource.create_texture #8640

Merged
merged 1 commit into from Mar 8, 2024
Merged

Clear the texture data if no buffer is passed in when using resource.create_texture #8640

merged 1 commit into from Mar 8, 2024

Conversation

Jhonnyg
Copy link
Contributor

@Jhonnyg Jhonnyg commented Mar 7, 2024 •
edited

We now explicitly clear the texture data before uploading it to the GPU texture when using resource.create_texture with no explicit buffer is being used.

Fixes #8489

@Jhonnyg Jhonnyg added the bug Something is not working as expected label Mar 7, 2024
@Jhonnyg Jhonnyg requested a review from JCash March 7, 2024 15:34
@Jhonnyg Jhonnyg added the engine Issues related to the Defold engine label Mar 7, 2024
@Jhonnyg Jhonnyg merged commit 0c891b9 into dev Mar 8, 2024
22 checks passed
@Jhonnyg Jhonnyg deleted the issue-8489-resource.create_texture-clearing branch March 8, 2024 10:15
Jhonnyg added a commit that referenced this pull request Mar 8, 2024
@Jhonnyg
Clear the texture data if no buffer is passed in (#8640)
bf4dc66
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JCash JCash JCash approved these changes

Assignees
No one assigned
Labels
bug Something is not working as expected engine Issues related to the Defold engine
Projects
No open projects
1.7.0
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Texture bleeding at runtime created texture & atlas
2 participants
@Jhonnyg @JCash