Move experimental vulkan functions to mainline graphics_vulkan library #8675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jhonnyg
commented
Mar 14, 2024
| @@ -221,6 +251,45 @@ namespace dmGraphics | |||
| TEXTURE_FORMAT_COUNT | |||
| }; | |||
|
|
|||
| struct PipelineState | |||
There was a problem hiding this comment.
Perhaps this doesn't need to live in the dmsdk? we could potentially do:
typedef struct PipelineState* HPipelineState
There was a problem hiding this comment.
It makes sense I think, as I think this struct may be a bit volatile.
Jhonnyg
commented
Mar 14, 2024
| ACCESS_FLAG_SHADER = 4, | ||
| }; | ||
|
|
||
| struct RenderPassDescriptor |
There was a problem hiding this comment.
Although we usually avoid putting structs in the dksdk, in this case it's fine because I doubt anyone else will use the vulkan dmsdk..
JCash
previously approved these changes
Mar 27, 2024
| @@ -221,6 +251,45 @@ namespace dmGraphics | |||
| TEXTURE_FORMAT_COUNT | |||
| }; | |||
|
|
|||
| struct PipelineState | |||
There was a problem hiding this comment.
It makes sense I think, as I think this struct may be a bit volatile.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the experimental vulkan API + library and instead moved all the code into the mainline vulkan library. This should make building the rive extension simpler (due to less dependencies) as well as merging some of the shared functionality later on.