Fix flickering on vulkan when drawing to a render target #8698
Conversation
| if (created_width != context->m_Width || created_height != context->m_Height) | ||
| { | ||
| dmPlatform::SetWindowSize(context->m_Window, created_width, created_height); | ||
| } |
There was a problem hiding this comment.
If the swapchain has been created at a different resolution we need to make sure the GLFW layer knows about the new updated resoultion.
| if (res != VK_SUCCESS && res != VK_SUBOPTIMAL_KHR) | ||
| { | ||
| CHECK_VK_ERROR(res); | ||
| } |
There was a problem hiding this comment.
This is a fix / workaround for android where the swap chain capabilities can have a presentation transform. For now we skip the transform completely by setting the currentTransform = identity, but that causes the presentation function to return a suboptimal result, which we don't care about right now.
There was a problem hiding this comment.
Would this be good info as a code comment, or is it easy to figure out?
There was a problem hiding this comment.
Yeah it's probably a good code comment, I will forget it otherwise
| @@ -153,6 +153,8 @@ namespace dmGraphics | |||
| capabilities.m_SurfaceCapabilities.maxImageCount); | |||
| } | |||
|
|
|||
| swap_chain_image_count = dmMath::Min(swap_chain_image_count, (uint32_t) DM_MAX_FRAMES_IN_FLIGHT); | |||
There was a problem hiding this comment.
We can only support a fixed amount of frame resources (and don't want to)
| if (res != VK_SUCCESS && res != VK_SUBOPTIMAL_KHR) | ||
| { | ||
| CHECK_VK_ERROR(res); | ||
| } |
There was a problem hiding this comment.
Would this be good info as a code comment, or is it easy to figure out?
Fixed an issue where flickering was happening on the Vulkan and MoltenVK renderers when using a render target.