Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check response status when fetch wasm for streaming instantiate. #8720

Merged
merged 1 commit into from Mar 27, 2024

Conversation

ekharkunov
Copy link
Contributor

@ekharkunov ekharkunov commented Mar 26, 2024

Check if fetch() was successful during wasm loading. Otherwise return Response with null body to trigger fallback logic.

Fixes #8091

Technical changes

Check if response.ok is true. Otherwise construct empty Response object with all headers and statuses from original response.
According to https://developer.mozilla.org/en-US/docs/Web/API/Response/body#value response.body can be empty. I tried to simulate it in following steps:

  1. Rename .wasm in bundle dir to something else. For example, game1111.wasm.
  2. Got error like wasm streaming instantiation failed! TypeError: WebAssembly: Response has unsupported MIME type 'text/html;charset=utf-8' expected 'application/wasm'
  3. Simulate 404 with content-type = application/wasm.
  4. Got error wasm streaming instantiation failed! TypeError: WebAssembly: Response does not have ok status (it was Response object that constructed as new Response(null, response)
  5. Loading going to fallback logic.

P.S. I can't reproduce situation when response.body is undefined. In case of 404 it was filled with html page content.

PR checklist

  • Code
    • Add engine and/or editor unit tests.
    • New and changed code follows the overall code style of existing code
    • Add comments where needed
  • Documentation
    • Make sure that API documentation is updated in code comments
    • Make sure that manuals are updated (in github.com/defold/doc)
  • Prepare pull request and affected issue for automatic release notes generator
    • Pull request - Write a message that explains what this pull request does. What was the problem? How was it solved? What are the changes to APIs or the new APIs introduced? This message will be used in the generated release notes. Make sure it is well written and understandable for a user of Defold.
    • Pull request - Write a pull request title that in a sentence summarises what the pull request does. Do not include "Issue-1234 ..." in the title. This text will be used in the generated release notes.
    • Pull request - Link the pull request to the issue(s) it is closing. Use on of the approved closing keywords.
    • Affected issue - Assign the issue to a project. Do not assign the pull request to a project if there is an issue which the pull request closes.
    • Affected issue - Assign the "breaking change" label to the issue if introducing a breaking change.
    • Affected issue - Assign the "skip release notes" is the issue should not be included in the generated release notes.

Example of a well written PR description:

  1. Start with the user facing changes. This will end up in the release notes.
  2. Add one of the GitHub approved closing keywords
  3. Optionally also add the technical changes made. This is information that might help the reviewer. It will not show up in the release notes. Technical changes are identified by a line starting with one of these:
    1. ### Technical changes
    2. Technical changes:
    3. Technical notes:
There was a anomaly in the carbon chroniton propeller, introduced in version 8.10.2. This fix will make sure to reset the phaser collector on application startup.

Fixes #1234

### Technical changes
* Pay special attention to line 23 of phaser_collector.clj as it contains some interesting optimizations
* The propeller code was not taking into account a negative phase.

@ekharkunov ekharkunov requested a review from AGulev March 26, 2024 13:55
@ekharkunov ekharkunov added bug Something is not working as expected html5 Issue related to the HTML5 platform labels Mar 26, 2024
@ekharkunov ekharkunov force-pushed the issue-8091-wasm-streaming-error branch from 9fca481 to 46381ce Compare March 26, 2024 14:03
Copy link
Contributor

@AGulev AGulev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ekharkunov ekharkunov merged commit d97392d into dev Mar 27, 2024
22 checks passed
@ekharkunov ekharkunov deleted the issue-8091-wasm-streaming-error branch March 29, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is not working as expected html5 Issue related to the HTML5 platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue when streaming the wasm build
2 participants