Support environment-variable replacement for usernames in dependency URLs #8754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matgis
added
bug
matgis
commented
Apr 3, 2024
| password (str ":" password)) | ||
| user-info-b64 (str->b64 user-info) | ||
| authorization (format "Basic %s" user-info-b64)] | ||
| {"Authorization" authorization})) |
There was a problem hiding this comment.
Previously only the password part of the URL supported environment variable replacement, but according to the docs we should also support it for the username: https://defold.com/manuals/libraries/#basic-access-authentication
| @@ -957,7 +957,7 @@ | |||
| num-strs) | |||
| first-col-width-fmt (str \% first-col-width \s) | |||
| rest-col-width-fmt (str \% rest-col-width \s) | |||
| fmt-col (fn [index num-str] | |||
| fmt-col (fn [^long index num-str] | |||
There was a problem hiding this comment.
Unrelated: Fixed boxed math warning.
britzl
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The editor can now inject environment variables into both the username and password of library dependency URLs that use authentication.