Support tangent space handedness #8871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matgis
requested changes
May 7, 2024
| :semantic-type :semantic-type-tangent | ||
| :coordinate-space :coordinate-space-world | ||
| :data-type :type-float | ||
| :element-count 4}])) |
There was a problem hiding this comment.
When using world-space meshes, the tangents in :tangent-data will be transformed by the renderable-data->world-direction-v4 function. Currently, this writes a zero for the W component when it calls the geom/transf-n4 function. I think we need to update geom/transf-n4 to pass along the unaltered W component.
It seems to me, we would need to do something similar on the engine side since we presumably transform the tangents using the normal matrix somewhere there as well, but I'm not seeing it in this PR? 🤔
There was a problem hiding this comment.
The engine preserves the handedness in Rig.cpp in the "GenerateNormalData" function.
JCash
previously approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tangents are now produced as vec4 in the engine, where the fourth component is the handedness of the tangent vector. This can then be used to calculate the correct tangent space vectors in a shader:
vec3 bitangent = cross(normal, tangent.xyz * tangent.w);Fixes #8733