This repository has been archived by the owner on Oct 10, 2021. It is now read-only.
feat: add browser_output_timeout and browser_retries option #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ add browser_output_timeout option, default to no timeout like before So that cloud testing does not hangs when uncaught exception thrown or any other funny thing Related to (but also useful for anyone) tape-testing/tape#127 and tape-testing/tape#134 This fixes #185 + add browser_retries option, default to 6 like before + some more debugging information to ease .. debugging
Before this commit, main errors thrown on zuul would result in an uncaught leaving a lot of browser opened. Now it does mean that any error like "timeout opening url" will now shutdown everything properly and show which browser failed at the end. Nice?
| @@ -1,4 +1,5 @@ | |||
| var debug = require('debug')('zuul'); | |||
| var omit = require('lodash').omit; | |||
There was a problem hiding this comment.
lodash.omit module instead
Also missing from package.json?
There was a problem hiding this comment.
lodash is already in package.json so we better reuse it than install a new 'lodash.omit' dependency right?
otherwise programmatic interface usage is broken. here we fix both command line and programmatic usage
|
gonna fix the ci tests, otherwise LGTY @defunctzombie? |
|
Tests ok! YAY! |
vvo
pushed a commit
to algolia/algoliasearch-helper-js
that referenced
this pull request
Jul 1, 2015
This pull request activates travis ci testing on master/develop and pull requests. In details: + CI testing on all currently supported browsers + CI testing on node 0.10, 0.12, iojs + `npm test` command that will: test phantom, test node, lint Package upgrades: - zuul: gzip assets + better error reporting (defunctzombie/zuul#220, defunctzombie/zuul#221) - browserify, eslint, sinon, tape, uglify-js Put `latest` for algoliasearch dev dependency, enforce being always on the latest version when testing. Some docs around contributing.
|
LGTM |
|
it's merging time |
vvo
pushed a commit
that referenced
this pull request
Jul 1, 2015
…gurable_retries feat: add browser_output_timeout and browser_retries option
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So that cloud testing does not hangs when uncaught exception thrown
or any other funny thing
Related to (but also useful for anyone) Remove uncaught-exception listener tape-testing/tape#127 and
Add section about uncaught exceptions to readme. tape-testing/tape#134
This fixes Any idea how to add timeout ? #185