Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(*): add readiness & liveness probes #149

Merged
merged 36 commits into from
Feb 16, 2016
Merged

fix(*): add readiness & liveness probes #149

merged 36 commits into from
Feb 16, 2016

Commits on Feb 12, 2016

  1. fix(pkg/healthz): add readiness & liveness probes

    Aaron Schlesinger committed Feb 12, 2016
    Configuration menu
    Copy the full SHA
    64cde22 View commit details
    Browse the repository at this point in the history

  2. fix(pkg/healthsrv/server.go): only access port 

    assume the health server will server on :$PORT
    Aaron Schlesinger committed Feb 12, 2016
    Configuration menu
    Copy the full SHA
    21ad624 View commit details
    Browse the repository at this point in the history

  3. feat(boot.go,pkg/sshd/config.go): wire up the health server

    Aaron Schlesinger committed Feb 12, 2016
    Configuration menu
    Copy the full SHA
    557bf6e View commit details
    Browse the repository at this point in the history

  4. fix(pkg/healthsrv/healthz_handler.go): pass in address of ListBuckets… 

    …Input
    Aaron Schlesinger committed Feb 12, 2016
    Configuration menu
    Copy the full SHA
    0dbe716 View commit details
    Browse the repository at this point in the history

  5. fix(pkg/healthsrv/healthz_handler.go): use internal log package

    Aaron Schlesinger committed Feb 12, 2016
    Configuration menu
    Copy the full SHA
    78ae20d View commit details
    Browse the repository at this point in the history

  6. fix(boot.go,fetcher/fetcher.go,pkg/sshd/config.go): unify all configs… 

    … and run the health server, fetcher and ssh server concurrently
    Aaron Schlesinger committed Feb 12, 2016
    Configuration menu
    Copy the full SHA
    c375e8a View commit details
    Browse the repository at this point in the history

  7. fix(manifests/*): bring manifests up to date with those in the deis-d… 

    …ev chart
    Aaron Schlesinger committed Feb 12, 2016
    Configuration menu
    Copy the full SHA
    20c7317 View commit details
    Browse the repository at this point in the history

  8. fix(manifests/deis-builder-rc.yaml): add health server port and env var

    Aaron Schlesinger committed Feb 12, 2016
    Configuration menu
    Copy the full SHA
    d733f4c View commit details
    Browse the repository at this point in the history

  9. fix(manifests/deis-builder-rc.yaml): use proper port name 

    kubectl complained about the old one
    Aaron Schlesinger committed Feb 12, 2016
    Configuration menu
    Copy the full SHA
    8891583 View commit details
    Browse the repository at this point in the history

  10. fix(pkg/healthsrv/server.go): build the right host string

    Aaron Schlesinger committed Feb 12, 2016
    Configuration menu
    Copy the full SHA
    9214a24 View commit details
    Browse the repository at this point in the history

  11. fix(boot.go,pkg/healthsrv): add kubernetes API checks in the healthz … 

    …endpoint
    Aaron Schlesinger committed Feb 12, 2016
    Configuration menu
    Copy the full SHA
    c1aebfc View commit details
    Browse the repository at this point in the history

  12. ref(pkg/healthsrv): refactor *s3.S3 out of the health server 

    Put the S3 functionality behind a small interface so that the server
can be unit tested later
    Aaron Schlesinger committed Feb 12, 2016
    Configuration menu
    Copy the full SHA
    f58ac45 View commit details
    Browse the repository at this point in the history

  13. feat(pkg/sshd/circuit*): add a circuit primitive 

    it will be used in the health probe, so the builder isn’t considered up
until the SSH server is actually running
    Aaron Schlesinger committed Feb 12, 2016
    Configuration menu
    Copy the full SHA
    f3755f6 View commit details
    Browse the repository at this point in the history

  14. fix(*): don't report the server up until the SSH server is running 

    the builder won’t be considered up until the SSH server is actually
running
    Aaron Schlesinger committed Feb 12, 2016
    Configuration menu
    Copy the full SHA
    96ec946 View commit details
    Browse the repository at this point in the history

  15. fix(pkg/sshd/circuit_test.go): add concurrency test for the circuit

    Aaron Schlesinger committed Feb 12, 2016
    Configuration menu
    Copy the full SHA
    e35609a View commit details
    Browse the repository at this point in the history

  16. fix(pkg/sshd/server_test.go): pass circuit to the server

    Aaron Schlesinger committed Feb 12, 2016
    Configuration menu
    Copy the full SHA
    e35e855 View commit details
    Browse the repository at this point in the history

  17. fix(pkg/healthsrv): add dummy bucket and namespace listers 

    they’ll be used in tests
    Aaron Schlesinger committed Feb 12, 2016
    Configuration menu
    Copy the full SHA
    b3dba97 View commit details
    Browse the repository at this point in the history

  18. fix(glide.yaml,glide.lock): add shameless plug assert package for tes… 

    …ting

it’s a shameless plug for my package, but it’s kinda handy
    Aaron Schlesinger committed Feb 12, 2016
    Configuration menu
    Copy the full SHA
    0dae532 View commit details
    Browse the repository at this point in the history

  19. fix(pkg/healthsrv): add tests to complete all failure cases in the he… 

    …alth probe handler
    Aaron Schlesinger committed Feb 12, 2016
    Configuration menu
    Copy the full SHA
    b039013 View commit details
    Browse the repository at this point in the history

  20. doc(pkg/healthsrv/healthz_handler.go): clarifying docs

    Aaron Schlesinger committed Feb 12, 2016
    Configuration menu
    Copy the full SHA
    4f1d853 View commit details
    Browse the repository at this point in the history

  21. fix(pkg/healthsrv/healthz_handler_test.go): adding success case test

    Aaron Schlesinger committed Feb 12, 2016
    Configuration menu
    Copy the full SHA
    b6a29a5 View commit details
    Browse the repository at this point in the history

  22. fix(manifests/deis-builder-rc.yaml): add probes to the RC manifest

    Aaron Schlesinger committed Feb 12, 2016
    Configuration menu
    Copy the full SHA
    4808fe1 View commit details
    Browse the repository at this point in the history

  23. fix(pkg/healthsrv): do the 3 health checks concurrently

    Aaron Schlesinger committed Feb 12, 2016
    Configuration menu
    Copy the full SHA
    b3fbb2b View commit details
    Browse the repository at this point in the history

  24. fix(glide.lock,glide.yaml,pkg/healthsrv/healthz_handler.go): use pkg/log

    Aaron Schlesinger committed Feb 12, 2016
    Configuration menu
    Copy the full SHA
    928a064 View commit details
    Browse the repository at this point in the history

  25. fix(boot.go): pass correct parameters to the right place

    Aaron Schlesinger committed Feb 12, 2016
    Configuration menu
    Copy the full SHA
    99f9d81 View commit details
    Browse the repository at this point in the history

  26. ref(pkg/sshd/server_test.go): make the server address constant

    Aaron Schlesinger committed Feb 12, 2016
    Configuration menu
    Copy the full SHA
    c9113b1 View commit details
    Browse the repository at this point in the history

  27. ref(pkg/sshd/server_test.go): remove unused func

    Aaron Schlesinger committed Feb 12, 2016
    Configuration menu
    Copy the full SHA
    d774e5f View commit details
    Browse the repository at this point in the history

  28. fix(rootfs/Dockerfile): move the git home and user env vars up 

    so that the adduser command works
    Aaron Schlesinger committed Feb 12, 2016
    Configuration menu
    Copy the full SHA
    5081ba5 View commit details
    Browse the repository at this point in the history

  29. fix(boot.go): use standard log package for startup 

    Builder seems to not print proper log messages with the
github.com/pkg/log package, but only on startup. This fixes that issue.
    Aaron Schlesinger committed Feb 12, 2016
    Configuration menu
    Copy the full SHA
    5a209b6 View commit details
    Browse the repository at this point in the history

  30. fix(manifests/deis-builder-rc.yaml): shorten the delay and timeout 

    now that the builder doesn’t need to wait for etcd to start, it should
come up much faster
    Aaron Schlesinger committed Feb 12, 2016
    Configuration menu
    Copy the full SHA
    f8fa37a View commit details
    Browse the repository at this point in the history

  31. fix(boot.go): fix additional debug message

    Aaron Schlesinger committed Feb 12, 2016
    Configuration menu
    Copy the full SHA
    ac6e83b View commit details
    Browse the repository at this point in the history

  32. ref(pkg/healthsrv/healthz_handler.go): simplify the healthcheck handler 

    make the logic to listen on multiple channels more straightforward, and
remove the logic to return health check info, as it’s not surfaced or
used anywhere…
    Aaron Schlesinger committed Feb 12, 2016
    Configuration menu
    Copy the full SHA
    666bb24 View commit details
    Browse the repository at this point in the history

  33. fix(Makefile): speed up all makefile builds 

    before, we ran ‘glide nv’ before *all* commands, but it was only used
in the ‘test’ target. this commit only runs it as part of that target
    Aaron Schlesinger committed Feb 12, 2016
    Configuration menu
    Copy the full SHA
    c925148 View commit details
    Browse the repository at this point in the history

  34. fix(pkg/healthsrv/server.go): remove unused constants

    Aaron Schlesinger committed Feb 12, 2016
    Configuration menu
    Copy the full SHA
    2b8fc3b View commit details
    Browse the repository at this point in the history

  35. doc(pkg/sshd/circuit.go): add more godocs

    Aaron Schlesinger committed Feb 12, 2016
    Configuration menu
    Copy the full SHA
    8952b25 View commit details
    Browse the repository at this point in the history

  36. fix(manifests/deis-builder-rc.yaml): remove fetcher port 

    The fetcher was removed in deis#171, but the port wasn’t removed from the
manifest in that PR. This removes it
    Aaron Schlesinger committed Feb 12, 2016
    Configuration menu
    Copy the full SHA
    958e0b1 View commit details
    Browse the repository at this point in the history