ref(builder): remove fetcher #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aledbf is this tested? |
aledbf
force-pushed
the
remove-fetcher
branch
from
2510270
to
0f0237c
Compare
|
@arschles yes but I forgot to push the |
|
@aledbf can you also submit a PR on https://github.com/deis/charts that removes the fetcher related things in the deis-builder manifests? I'm guessing the only change will have to be on the |
|
@aledbf can you also remove the |
aledbf
force-pushed
the
remove-fetcher
branch
from
0f0237c
to
c687390
Compare
aledbf
force-pushed
the
remove-fetcher
branch
from
c687390
to
00a5199
Compare
|
good to merge :) |
5 tasks
arschles
pushed a commit
to arschles/deis-builder
that referenced
this pull request
Feb 12, 2016
The fetcher was removed in deis#171, but the port wasn’t removed from the manifest in that PR. This removes it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #139
closes #6