fix(scheduler): cast ports to int before passing them on to k8s

when doing config:set PORT=80 then k8s complains that 80 is not a valid port / name
deis · Jun 7, 2016 · 5910902 · 5910902
1 parent 816a36b
commit 5910902
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/rootfs/scheduler/__init__.py b/rootfs/scheduler/__init__.py
@@ -464,7 +464,7 @@ def _update_application_service(self, namespace, name, app_type, port, routable=
                 for pos, item in enumerate(service['spec']['ports']):
                     if item['port'] == 80 and port != item['targetPort']:
                         # port 80 is the only one we care about right now
-                        service['spec']['ports'][pos]['targetPort'] = port
+                        service['spec']['ports'][pos]['targetPort'] = int(port)
 
             self._update_service(namespace, namespace, data=service)
         except Exception as e:
@@ -1181,7 +1181,7 @@ def _healthcheck(self, namespace, container, routable=False, path='/', port=5000
                 # an http probe
                 'httpGet': {
                     'path': path,
-                    'port': port
+                    'port': int(port)
                 },
                 # length of time to wait for a pod to initialize
                 # after pod startup, before applying health checking
@@ -1195,7 +1195,7 @@ def _healthcheck(self, namespace, container, routable=False, path='/', port=5000
                 # an http probe
                 'httpGet': {
                     'path': path,
-                    'port': port
+                    'port': int(port)
                 },
                 # length of time to wait for a pod to initialize
                 # after pod startup, before applying health checking
@@ -1264,7 +1264,7 @@ def _default_dockerapp_readiness_probe(self, port, delay=5, timeout=5, period_se
             'readinessProbe': {
                 # an exec probe
                 'tcpSocket': {
-                    "port": port
+                    "port": int(port)
                 },
                 # length of time to wait for a pod to initialize
                 # after pod startup, before applying health checking