Skip to content
This repository has been archived by the owner on May 6, 2020. It is now read-only.

Expose user/app checking for Builder in a builder specific hook #335

Closed
helgi opened this issue Feb 3, 2016 · 4 comments
Closed

Expose user/app checking for Builder in a builder specific hook #335

helgi opened this issue Feb 3, 2016 · 4 comments
Assignees
Milestone

Comments

@helgi
Copy link
Contributor

helgi commented Feb 3, 2016

Relates to deis/builder#81 and deis/builder#122

TL;DR from deis/builder#122 (has a more detailed discussion)

Expose GET /v2/hooks/keys/$APP_NAME and GET /v2/hooks/keys/$APP_NAME/$USER_NAME endpoints for Builder Auth Key only where it returns 404 when APP_NAME or USER_NAME are missing.

Return body will be {"users": {"aaron": "keysandthings"}} for the APP_NAME specific hook and {"key": "keysandthings"} for the per user hook

@helgi helgi self-assigned this Feb 3, 2016
@helgi helgi added this to the v2.0-beta1 milestone Feb 3, 2016
@arschles
Copy link
Member

arschles commented Feb 3, 2016

@helgi is "keysandthings" gonna be just the pub key for the user?

@helgi
Copy link
Contributor Author

helgi commented Feb 3, 2016

Yeah, whatever the key is that you need in the builder, which is the public

@helgi
Copy link
Contributor Author

helgi commented Feb 3, 2016

I changed it so that the APP_NAME/USER_NAME endpoint returns {"$USERNAME": "$KEY"}

If we want to support multiple keys per user then I could change the key part into a list - Thoughts?

@arschles
Copy link
Member

arschles commented Feb 3, 2016

I changed it so that the APP_NAME/USER_NAME endpoint returns {"$USERNAME": "$KEY"}

👍

If we want to support multiple keys per user then I could change the key part into a list - Thoughts?

So the response body would look like the following?

{"users":[{"$USERNAME":"$KEY"},...]}

helgi added a commit to helgi/controller that referenced this issue Feb 3, 2016
Give builder the ability to query for application or application + user and get the public key associated if both resource exist.
Replaces etcd usage for builder.

Fixes deis#335
helgi added a commit to helgi/controller that referenced this issue Feb 3, 2016
Give builder the ability to query for application or application + user and get the public key associated if both resource exist.
Replaces etcd usage for builder.

Fixes deis#335
helgi added a commit to helgi/controller that referenced this issue Feb 4, 2016
Give builder the ability to query for application or application + user and get the public key associated if both resource exist.
Replaces etcd usage for builder.

Fixes deis#335
helgi added a commit to helgi/controller that referenced this issue Feb 4, 2016
Give builder the ability to query for application or application + user and get the public key associated if both resource exist.
Replaces etcd usage for builder.

Fixes deis#335
@helgi helgi closed this as completed in #336 Feb 4, 2016
@helgi helgi removed the in progress label Feb 4, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants