-
Notifications
You must be signed in to change notification settings - Fork 53
Private registry spike #639
Comments
The way I like to think about this is 3 phases:
|
Ok. On point 1, we differ. I was thinking we skip the "shoveling" into the internal registry, but you're thinking we keep that and the thing we skip is any I'm fine with that. That seems pretty reasonable. |
Actually... I am confused now about where we're hoping to land eventually. No. 1 has us skipping the No. 2 has us using These two are opposites of one another. So what do we achieve then? Is the idea that you want to be able to support both? |
We wouldn't support both until we hit point 3 but that gets into more configuration nightmare. It's mostly about time and momentum really :) If we get controller talking to external registry very fast and on all levels (the original meta ticket) without issues then we can move to the We need to figure out how the workflows will look, if we are doing We can't spend beta3 and beta4 on this so we are trying to time box things. crawl, walk, run :) |
use a k8s Secret to encode a '.docker/config.json' to completely bypass the Controller when it comes to images if a private registry is being used Handles the various possible errors coming from k8s and bubble that up through to the end user, similar to how the deis dockerclient can do. k8s adds more information on top of what docker gives so an error message bubbled up from this compared to when the Controller was handling the Docker interaction ref deis#639
use a k8s Secret to encode a '.docker/config.json' to completely bypass the Controller when it comes to images if a private registry is being used Handles the various possible errors coming from k8s and bubble that up through to the end user, similar to how the deis dockerclient can do. k8s adds more information on top of what docker gives so an error message bubbled up from this compared to when the Controller was handling the Docker interaction ref deis#639
use a k8s Secret to encode a '.docker/config.json' to completely bypass the Controller when it comes to images if a private registry is being used Handles the various possible errors coming from k8s and bubble that up through to the end user, similar to how the deis dockerclient can do. k8s adds more information on top of what docker gives so an error message bubbled up from this compared to when the Controller was handling the Docker interaction ref deis#639
use a k8s Secret to encode a '.docker/config.json' to completely bypass the Controller when it comes to images if a private registry is being used Handles the various possible errors coming from k8s and bubble that up through to the end user, similar to how the deis dockerclient can do. k8s adds more information on top of what docker gives so an error message bubbled up from this compared to when the Controller was handling the Docker interaction ref deis#639
use a k8s Secret to encode a '.docker/config.json' to completely bypass the Controller when it comes to images if a private registry is being used Handles the various possible errors coming from k8s and bubble that up through to the end user, similar to how the deis dockerclient can do. k8s adds more information on top of what docker gives so an error message bubbled up from this compared to when the Controller was handling the Docker interaction ref deis#639
use a k8s Secret to encode a '.docker/config.json' to completely bypass the Controller when it comes to images if a private registry is being used Handles the various possible errors coming from k8s and bubble that up through to the end user, similar to how the deis dockerclient can do. k8s adds more information on top of what docker gives so an error message bubbled up from this compared to when the Controller was handling the Docker interaction ref deis#639
use a k8s Secret to encode a '.docker/config.json' to completely bypass the Controller when it comes to images if a private registry is being used Handles the various possible errors coming from k8s and bubble that up through to the end user, similar to how the deis dockerclient can do. k8s adds more information on top of what docker gives so an error message bubbled up from this compared to when the Controller was handling the Docker interaction ref deis#639
use a k8s Secret to encode a '.docker/config.json' to completely bypass the Controller when it comes to images if a private registry is being used Handles the various possible errors coming from k8s and bubble that up through to the end user, similar to how the deis dockerclient can do. k8s adds more information on top of what docker gives so an error message bubbled up from this compared to when the Controller was handling the Docker interaction ref deis#639
use a k8s Secret to encode a '.docker/config.json' to completely bypass the Controller when it comes to images if a private registry is being used Handles the various possible errors coming from k8s and bubble that up through to the end user, similar to how the deis dockerclient can do. k8s adds more information on top of what docker gives so an error message bubbled up from this compared to when the Controller was handling the Docker interaction ref deis#639
use a k8s Secret to encode a '.docker/config.json' to completely bypass the Controller when it comes to images if a private registry is being used Handles the various possible errors coming from k8s and bubble that up through to the end user, similar to how the deis dockerclient can do. k8s adds more information on top of what docker gives so an error message bubbled up from this compared to when the Controller was handling the Docker interaction ref deis#639
Going to close this now that #718 has been merged |
use a k8s Secret to encode a '.docker/config.json' to completely bypass the Controller when it comes to images if a private registry is being used Handles the various possible errors coming from k8s and bubble that up through to the end user, similar to how the deis dockerclient can do. k8s adds more information on top of what docker gives so an error message bubbled up from this compared to when the Controller was handling the Docker interaction ref deis#639
feat(azure): Add docs to specify support for the azure container registry
This issue is a place for us to hammer out our approach to resolving #253
cc @helgi @kmala
Discussed offline earlier today:
Will prove the concept first:
deis config:set
. This will be replaced with a well-thought-out UX and necessary CLI changes before the feature is released.deis config:set
-- again, this is temporary.imagePullSecret
from relevant app configuration and make app RCs reference the same.deis builds:create
/deis pull
.With the concept proven:
imagePullSecret
for the internal registry. This would not be specified bydeis
users, but could be auto-generated (when an app is created?). Any registry authentication details provided by the user would be used by the controller to pull images from the private registry before pushing said images to the internal registry-- i.e. similar to what we do today, and correcting for the fact that the PoC will likely bypass this step.@helgi correct me, please, if any of this seems to differ from what we discussed.
The text was updated successfully, but these errors were encountered: