fix(tests): lower cyclomatic complexity of Checklist

It was a little confusing to read the different cases, so I lowered the complexity in order to read through the code for future readers.
deis · Mar 20, 2015 · ea765c8 · ea765c8
1 parent 6328afe
commit ea765c8
Showing 1 changed file with 4 additions and 5 deletions.
diff --git a/tests/utils/itutils.go b/tests/utils/itutils.go
@@ -196,11 +196,10 @@ func CheckList(
 	if err != nil {
 		t.Fatal(err)
 	}
-	if strings.Contains(stdout.String(), contain) == notflag {
-		if notflag {
-			t.Fatalf(
-				"Didn't expect '%s' in command output:\n%v", contain, stdout)
-		}
+	if notflag && strings.Contains(stdout.String(), contain) {
+		t.Fatalf("Didn't expect '%s' in command output:\n%v", contain, stdout)
+	}
+	if !notflag && !strings.Contains(stdout.String(), contain) {
 		t.Fatalf("Expected '%s' in command output:\n%v", contain, stdout)
 	}
 }