This repository has been archived by the owner on Nov 30, 2021. It is now read-only.
fix(controller): kill processes removed from procfile #3068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like the clean implementation. Code LGTM! |
|
Great to have this fixed. Code LGTM. |
bacongobbler
force-pushed
the
2930-kill-processes-removed-from-procfile
branch
from
453ae8c
to
c49a15c
Compare
|
@bacongobbler with this PR I see this error in the controller: |
|
The unit tests are failing so there's bound to be issues :) |
When a process type is removed in a new build, the old containers are not killed, and there's no way for the user to stop them. This change will destroy the containers that no longer exist in the procfile.
bacongobbler
force-pushed
the
2930-kill-processes-removed-from-procfile
branch
from
c49a15c
to
05c322c
Compare
|
fixed and tests passing, PTAL when you have time :) |
|
Code LGTM. |
|
Code LGTM still. 😄 |
bacongobbler
pushed a commit
that referenced
this pull request
Feb 23, 2015
…d-from-procfile fix(controller): kill processes removed from procfile
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a process type is removed in a new build, the old containers are
not killed, and there's no way for the user to stop them. This change
will destroy the containers that no longer exist in the procfile.
closes #2930