This repository has been archived by the owner on Nov 30, 2021. It is now read-only.
Updated docs_requirements.txt, fixed warnings and api.admin docs. #637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -10,7 +10,7 @@ Architecture | |||
| Deis consists of 9 modules that combine to create a distributed PaaS. | |||
| Each Deis module is deployed as a :ref:`Container`. | |||
|
|
|||
| .. _controller: | |||
| .. _arch_controller: | |||
There was a problem hiding this comment.
Won't this break links like the one in the getting started docs?
There was a problem hiding this comment.
We have a collision in Sphinx since we defined the link "_controller" twice, so currently it is a circular reference:
http://docs.deis.io/en/latest/gettingstarted/architecture/#controller
It appears to me we mean to refer to this:
http://docs.deis.io/en/latest/components/controller/
when we reference a canonical "controller" link within the docs, so renaming this one to _arch_controller seems to fix things.
|
LGTM |
bacongobbler
pushed a commit
that referenced
this pull request
Mar 17, 2014
Updated docs_requirements.txt, fixed warnings and api.admin docs.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.