Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(deis component health): Refactored deis components health dashboards #135

Merged
merged 1 commit into from
Aug 29, 2016

Conversation

jchauncey
Copy link
Member

@jchauncey jchauncey commented Aug 25, 2016

  • Use the pod name for tagging data instead of container name
  • Removed non-negative-derivative from some memory graphs
  • rearranged graphs to be in alphabetical order
  • Add refresh of 5s
  • Change time resolution to 3 hours

@jchauncey jchauncey added this to the v2.5 milestone Aug 25, 2016
@jchauncey jchauncey self-assigned this Aug 25, 2016
@deis-bot
Copy link

@smothiki is a potential reviewer of this pull request based on my analysis of git blame information. Thanks @jchauncey!

@helgi
Copy link
Contributor

helgi commented Aug 25, 2016

What is the resolution time changing from?

@jchauncey jchauncey force-pushed the update-deis-component-dashboard branch 2 times, most recently from 302145e to 41680c1 Compare August 25, 2016 16:49
@jchauncey
Copy link
Member Author

6 hours

@jchauncey
Copy link
Member Author

I just changed it again. It was 5 mins but I changed it to 3 hours

@helgi
Copy link
Contributor

helgi commented Aug 25, 2016

What's the reason to change? and why change it to 3 after 5 mins? :)

@jchauncey
Copy link
Member Author

Most of our dashboards use a 5 minute resolution so I first wanted it to be consistent. 6 hours means it takes a while for the graph to really show a problem. Felt like 3 hours was a good compromise

@jchauncey jchauncey force-pushed the update-deis-component-dashboard branch from 41680c1 to 368d2d3 Compare August 25, 2016 17:44
@helgi
Copy link
Contributor

helgi commented Aug 25, 2016

Telegraf memory graphs are showing up as undefined - The CPU name of one of the pods is deis-monitor-telegraf-f1sbj

The Redis memory graph has a lot of granularity, 5.3454534543534MB

Under Registry it seems both registry and token refresher show up as the same name in the memory graph

* Use the pod name for tagging data instead of container name
* Removed non-negative-derivative from some memory graphs
* rearranged graphs to be in alphabetical order
* Add refresh of 5s
* Change time resolution to 3 hours
* Changed CPU groupby time to 60s to help smooth out the graphs
@jchauncey jchauncey force-pushed the update-deis-component-dashboard branch from 368d2d3 to 1dfc015 Compare August 25, 2016 20:38
@jchauncey
Copy link
Member Author

I cant do much about the granularity and I did not see anything about the token refresher show up in my memory graphs.

@helgi
Copy link
Contributor

helgi commented Aug 25, 2016

The refresh token name now shows up properly.

Is there no way to define a rounding anywhere on the memory info? We have to do it on the info as we store it?

@jchauncey
Copy link
Member Author

I can investigate and see if we can round the values

On Aug 25, 2016 4:50 PM, "Helgi Þormar Þorbjörnsson" <
notifications@github.com> wrote:

The refresh token name now shows up properly.

Is there no way to define a rounding anywhere on the memory info? We have
to do it on the info as we store it?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#135 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAaRGCMrGu87IumWeHkUENzjdMxzRvd9ks5qjgAJgaJpZM4JtRqJ
.

@helgi helgi added the LGTM1 label Aug 29, 2016
@jchauncey jchauncey merged commit b89ff4c into deis:master Aug 29, 2016
@jchauncey jchauncey deleted the update-deis-component-dashboard branch August 29, 2016 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants