-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref(deis component health): Refactored deis components health dashboards #135
ref(deis component health): Refactored deis components health dashboards #135
Conversation
jchauncey
commented
Aug 25, 2016
•
edited
Loading
edited
- Use the pod name for tagging data instead of container name
- Removed non-negative-derivative from some memory graphs
- rearranged graphs to be in alphabetical order
- Add refresh of 5s
- Change time resolution to 3 hours
@smothiki is a potential reviewer of this pull request based on my analysis of |
What is the resolution time changing from? |
302145e
to
41680c1
Compare
6 hours |
I just changed it again. It was 5 mins but I changed it to 3 hours |
What's the reason to change? and why change it to 3 after 5 mins? :) |
Most of our dashboards use a 5 minute resolution so I first wanted it to be consistent. 6 hours means it takes a while for the graph to really show a problem. Felt like 3 hours was a good compromise |
41680c1
to
368d2d3
Compare
Telegraf memory graphs are showing up as The Redis memory graph has a lot of granularity, Under Registry it seems both registry and token refresher show up as the same name in the memory graph |
* Use the pod name for tagging data instead of container name * Removed non-negative-derivative from some memory graphs * rearranged graphs to be in alphabetical order * Add refresh of 5s * Change time resolution to 3 hours * Changed CPU groupby time to 60s to help smooth out the graphs
368d2d3
to
1dfc015
Compare
I cant do much about the granularity and I did not see anything about the token refresher show up in my memory graphs. |
The refresh token name now shows up properly. Is there no way to define a rounding anywhere on the memory info? We have to do it on the info as we store it? |
I can investigate and see if we can round the values On Aug 25, 2016 4:50 PM, "Helgi Þormar Þorbjörnsson" <
|