Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(Dockerfile): Refactor image to use ubuntu-slim #103

Merged
merged 1 commit into from
May 23, 2016
Merged

chore(Dockerfile): Refactor image to use ubuntu-slim #103

merged 1 commit into from
May 23, 2016

Conversation

krancour
Copy link
Contributor

No description provided.

@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @bacongobbler, @kmala and @vdice to be potential reviewers

@krancour krancour added this to the v2.0-rc1 milestone May 20, 2016
@krancour krancour self-assigned this May 20, 2016
@mboersma mboersma added the LGTM1 label May 23, 2016

RUN apt-key adv --keyserver ha.pool.sks-keyservers.net --recv-keys B97B0AFCAA1A47F044F244A07FCC7D46ACCC4CF8
# Set this separately from those above since it depends on one of them
ENV PATH=/usr/lib/postgresql/$PG_MAJOR/bin:$PATH
Copy link
Member

@arschles arschles May 23, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merge this layer with the above ENV layer? or, will it not let you use env vars created in the same layer...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct... per the comment on line 9.

@krancour krancour merged commit f502600 into deis:master May 23, 2016
@krancour krancour deleted the image-madness branch May 23, 2016 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants