feat(Makefile): build using dockefile and slim image size #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@arschles, @vdice and @helgi are potential reviewers of this pull request based on my analysis of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch to building within the dockerfile as well.
This also excludes unneeded files from the container, so the
COPYstep at the end remains fast.On my macbook a cached containerized
make buildtakes the same amount of time as ago buildon the host machine.This also slims up test images, hopefully speeding up CI.
Another bonus: No more, "did you run
make glideup". Dockers caching system will automatically download new dependencies when they change._dist/deisso that you don't have to mount the entire working directory into the docker container.