Skip to content
This repository has been archived by the owner on Nov 30, 2021. It is now read-only.

feat(customizing-workflow): add component tuning #139

Merged
merged 1 commit into from
May 11, 2016

Conversation

bacongobbler
Copy link
Member

In v1 we had a section dedicated to customizations that users could
add to each component. This brings back that documentation back,
adding only controller and database-specific customizations to the
mix with others to be added as necessary.

addresses #75

@bacongobbler bacongobbler self-assigned this Apr 7, 2016
@bacongobbler bacongobbler added this to the v2.0-beta2 milestone Apr 7, 2016
Setting | Description
------------------- | ---------------------------------
REGISTRATION_MODE | set registration to “enabled”, “disabled”, or “admin_only” (default: “enabled”)
GUNICORN_WORKERS | number of gunicorn workers spawned to process requests (default: 8)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe a link here that overviews what a gunicorn worker is (even better, with some config tips)?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good thought.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We only default to 8 if the worker count can't be calculated: https://github.com/deis/controller/blob/master/rootfs/deis/gconf.py

@@ -0,0 +1,46 @@
# Tuning Component Settings

Helm Charts are a unit of Kubernetes manifests that reflect best practices to deploy an application
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say a "set" or "group" of Kubernetes manifests rather than a "unit."

is to Homebrew.

When you run `helm fetch deis/workflow-beta1`, you can customize the chart with
`helm edit workflow-beta1`. To customize the respective component, edit
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to deis/workflow-beta2?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do. It was expected that this would be merged before we shipped beta2. Thanks for finding this!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I bumped it to beta3 since we're attempting to cut that release this week.

[formula model](https://github.com/Homebrew/homebrew-core). A Helm chart is to Helm as a Formula
is to Homebrew.

When you run `helm fetch deis/workflow-beta3`, you can customize the chart with
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should say helmc now, same for the next line.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed.

@bacongobbler
Copy link
Member Author

@jchauncey wanna hold on merging this until after we cut rc1? Don't want to block the release for ya

@jchauncey
Copy link
Member

yeah lets just hold off now until rc1. ill move this to that milestone

@jchauncey jchauncey modified the milestones: v2.0-rc1, v2.0-beta4 May 10, 2016
In v1 we had a section dedicated to customizations that users could
add to each component. This brings back that documentation back,
adding only controller and database-specific customizations to the
mix with others to be added as necessary.
@bacongobbler bacongobbler merged commit 9e9fc03 into deis:master May 11, 2016
@bacongobbler bacongobbler deleted the 75-customizing-workflow branch May 11, 2016 21:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants