-
Notifications
You must be signed in to change notification settings - Fork 181
feat(customizing-workflow): add component tuning #139
feat(customizing-workflow): add component tuning #139
Conversation
Setting | Description | ||
------------------- | --------------------------------- | ||
REGISTRATION_MODE | set registration to “enabled”, “disabled”, or “admin_only” (default: “enabled”) | ||
GUNICORN_WORKERS | number of gunicorn workers spawned to process requests (default: 8) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe a link here that overviews what a gunicorn worker is (even better, with some config tips)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good thought.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We only default to 8
if the worker count can't be calculated: https://github.com/deis/controller/blob/master/rootfs/deis/gconf.py
110b860
to
49d6dd6
Compare
@@ -0,0 +1,46 @@ | |||
# Tuning Component Settings | |||
|
|||
Helm Charts are a unit of Kubernetes manifests that reflect best practices to deploy an application |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would say a "set" or "group" of Kubernetes manifests rather than a "unit."
49d6dd6
to
c7a2b00
Compare
is to Homebrew. | ||
|
||
When you run `helm fetch deis/workflow-beta1`, you can customize the chart with | ||
`helm edit workflow-beta1`. To customize the respective component, edit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change to deis/workflow-beta2
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will do. It was expected that this would be merged before we shipped beta2. Thanks for finding this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I bumped it to beta3 since we're attempting to cut that release this week.
c7a2b00
to
ed4b26f
Compare
[formula model](https://github.com/Homebrew/homebrew-core). A Helm chart is to Helm as a Formula | ||
is to Homebrew. | ||
|
||
When you run `helm fetch deis/workflow-beta3`, you can customize the chart with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should say helmc
now, same for the next line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agreed.
@jchauncey wanna hold on merging this until after we cut rc1? Don't want to block the release for ya |
yeah lets just hold off now until rc1. ill move this to that milestone |
In v1 we had a section dedicated to customizations that users could add to each component. This brings back that documentation back, adding only controller and database-specific customizations to the mix with others to be added as necessary.
ed4b26f
to
a96ed26
Compare
In v1 we had a section dedicated to customizations that users could
add to each component. This brings back that documentation back,
adding only controller and database-specific customizations to the
mix with others to be added as necessary.
addresses #75