-
Notifications
You must be signed in to change notification settings - Fork 181
feat(managing-workflow): add back production deployments #141
Conversation
relies on #139 before this can go green, since this doc references that PR |
refs #79 |
@@ -1,3 +1,57 @@ | |||
# Production Deployments | |||
|
|||
TODO (bacongobbler): rewrite for v2 | |||
Many Workflow users are running Workflow quite successfully in production. When readying a Workflow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume this is a forward-looking statement. Still, I would drop the first sentence completely until such time as it becomes accurate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed. This is definitely a little forward-thinking. It was a copy-over from the old v1 documentation.
This has a broken hyperlink:
|
@mboersma see #141 (comment) above :) |
af74e76
to
607d726
Compare
|
||
Workflow makes use of [Minio][] to provide persistent storage for the [Registry][], [Database][], | ||
and [Logger][] components. The additional operational complexity of Minio is tolerated because of | ||
the need for persistent storage for platform high availability. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it's accurate to describe Minio as complex. Also "high availability" implies that deis/minio is resilient in ways it unfortunately isn't.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Honestly, maybe just use "storage" instead of "persistent storage" throughout this paragraph, and drop the "high availability" phrase.
|
All great points. Thanks @mboersma! Most of this is a rip from the old "production deployments" doc but I agree that a lot of it does not make sense now. I've already had to edit the old doc quite a bit, so thank you for picking up on where I've missed! I'll rip those out. |
and @mboersma see above, you already pointed that out in #141 (comment). I'm still waiting on #139 to be merged before that hyperlink won't break any more. |
607d726
to
ca37b61
Compare
ca37b61
to
869a810
Compare
@mboersma all comments have been addressed. Thank you for taking the time to review. :) |
No description provided.