Skip to content
This repository has been archived by the owner on Nov 30, 2021. It is now read-only.

feat(managing-workflow): add back production deployments #141

Merged
merged 1 commit into from
May 24, 2016

Conversation

bacongobbler
Copy link
Member

No description provided.

@bacongobbler bacongobbler self-assigned this Apr 7, 2016
@bacongobbler bacongobbler added this to the v2.0-beta2 milestone Apr 7, 2016
@bacongobbler
Copy link
Member Author

relies on #139 before this can go green, since this doc references that PR

@bacongobbler
Copy link
Member Author

refs #79

@mboersma mboersma added the docs label Apr 10, 2016
@@ -1,3 +1,57 @@
# Production Deployments

TODO (bacongobbler): rewrite for v2
Many Workflow users are running Workflow quite successfully in production. When readying a Workflow
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this is a forward-looking statement. Still, I would drop the first sentence completely until such time as it becomes accurate.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. This is definitely a little forward-thinking. It was a copy-over from the old v1 documentation.

@bacongobbler bacongobbler modified the milestones: v2.0-beta3, v2.0-beta2 Apr 13, 2016
@mboersma
Copy link
Member

This has a broken hyperlink:

Error: The page "managing-workflow/production-deployments.md" contained a hyperlink to "customizing-workflow/tuning-component-settings.md" which is not listed in the "pages" configuration.

@bacongobbler
Copy link
Member Author

@mboersma see #141 (comment) above :)

@bacongobbler bacongobbler force-pushed the production-deployments branch 2 times, most recently from af74e76 to 607d726 Compare April 25, 2016 18:34
@arschles arschles mentioned this pull request Apr 25, 2016
@bacongobbler bacongobbler modified the milestones: v2.0-beta4, v2.0-beta3 Apr 25, 2016

Workflow makes use of [Minio][] to provide persistent storage for the [Registry][], [Database][],
and [Logger][] components. The additional operational complexity of Minio is tolerated because of
the need for persistent storage for platform high availability.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it's accurate to describe Minio as complex. Also "high availability" implies that deis/minio is resilient in ways it unfortunately isn't.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly, maybe just use "storage" instead of "persistent storage" throughout this paragraph, and drop the "high availability" phrase.

@mboersma
Copy link
Member

DEBUG   -  Building page managing-workflow/production-deployments.md 
ERROR   -  Error building page managing-workflow/production-deployments.md 
Error: The page "managing-workflow/production-deployments.md" contained a hyperlink to "customizing-workflow/tuning-component-settings.md" which is not listed in the "pages" configuration.
make: *** [build] Error 1

@bacongobbler
Copy link
Member Author

All great points. Thanks @mboersma! Most of this is a rip from the old "production deployments" doc but I agree that a lot of it does not make sense now. I've already had to edit the old doc quite a bit, so thank you for picking up on where I've missed! I'll rip those out.

@bacongobbler
Copy link
Member Author

and @mboersma see above, you already pointed that out in #141 (comment). I'm still waiting on #139 to be merged before that hyperlink won't break any more.

@bacongobbler
Copy link
Member Author

@mboersma all comments have been addressed. Thank you for taking the time to review. :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants