Added cwd configuration from cmdline to kernel #105
Conversation
| /* process CWD. Can be set on differnt threads so need to protect it too | ||
| */ | ||
| char* cwd; | ||
| myst_spinlock_t cwd_lock; |
There was a problem hiding this comment.
It seems we are stuffing more process-wise fields in myst_thread_t. At some point we have to separate out a myst_process_t to keep the size of myst_thread_t managable.
There was a problem hiding this comment.
that is something that has concerned me. May want to create an issue on that
There was a problem hiding this comment.
We can use a union in struct thread (to overlap thread and process fields).
There was a problem hiding this comment.
processes also have thread items too
| @@ -565,6 +560,12 @@ int myst_enter_kernel(myst_kernel_args_t* args) | |||
| thread->main.exec_crt_data = NULL; | |||
| thread->main.exec_crt_size = 0; | |||
| } | |||
| /* unmap any mapping made by the process */ | |||
| myst_release_process_mappings(thread->pid); | |||
There was a problem hiding this comment.
The main process should never unmap itself. I think this clean up is unnecessary.
There was a problem hiding this comment.
it causes a leak
tests/myst/cwd-config/main.c
Outdated
| assert(WIFEXITED(wstatus)); | ||
| assert(WEXITSTATUS(wstatus) == 0); | ||
|
|
||
| // should still be / |
There was a problem hiding this comment.
Either the comment is wrong or the assertion below is wrong.
There was a problem hiding this comment.
cut and paste bug! fixing
* takes config from config.json * plumbs through kernel * fixed kernel to use cwd settings for each process * added parsing of config for linux target although not all settings are decoded yet
kernel/exec.c
Outdated
| @@ -811,6 +811,7 @@ int myst_exec( | |||
| const char* argv[], | |||
| size_t envc, | |||
| const char* envp[], | |||
| MYST_UNUSED const char* current_working_directory, | |||
There was a problem hiding this comment.
This is actually used below. Should we remove MYST_UNUSED?
There was a problem hiding this comment.
I have already removed that
decoded yet